Skip to content

Update onnxruntime tests - #8462

Open
jcrist wants to merge 1 commit into
NVIDIA:mainfrom
jcrist:update-onnx-tests
Open

Update onnxruntime tests#8462
jcrist wants to merge 1 commit into
NVIDIA:mainfrom
jcrist:update-onnx-tests

Conversation

@jcrist

@jcrist jcrist commented Aug 10, 2026

Copy link
Copy Markdown
Member
  • Re-enable tests on Python 3.14, onnx now ships packages for this python version
  • Gate RandomForestClassifier xfail to apply only to onnxruntime < 1.28.0

This should fix the failures seen in the nightlies last night (link). The latest onnxruntime version was just released on conda-forge, triggering the failures.

- Re-enable tests on Python 3.14, onnx now ships packages for this
  python version
- Gate `RandomForestClassifier` xfail to apply only to
  `onnxruntime < 1.28.0`
@jcrist jcrist self-assigned this Aug 10, 2026
@jcrist
jcrist requested review from a team as code owners August 10, 2026 17:27
@jcrist jcrist added the improvement Improvement / enhancement to an existing function label Aug 10, 2026
@jcrist
jcrist requested a review from bdice August 10, 2026 17:27
@jcrist jcrist added the non-breaking Non-breaking change label Aug 10, 2026
@jcrist
jcrist requested a review from csadorf August 10, 2026 17:27
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7393f0e9-18a7-4fff-a0b2-b76e704d5b9a

📥 Commits

Reviewing files that changed from the base of the PR and between 342457b and 0771e39.

📒 Files selected for processing (3)
  • dependencies.yaml
  • python/cuml/cuml_accel_tests/test_onnx.py
  • python/cuml/pyproject.toml

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes

    • Improved ONNX Runtime compatibility across supported Python environments.
    • Updated Random Forest ONNX tests to account for behavior differences between ONNX Runtime versions.
  • Tests

    • ONNX-related test dependencies are now consistently available in test environments.
    • Newer ONNX Runtime versions can run the relevant test without an unnecessary expected-failure marker.

Walkthrough

The change enables onnxruntime and skl2onnx for tests. The ONNX Runtime version now controls the expected-failure marker for the RandomForestClassifier test.

Changes

ONNX test dependency and version gating

Layer / File(s) Summary
Enable ONNX test dependencies
dependencies.yaml, python/cuml/pyproject.toml
The shared and project-specific test dependency sets include onnxruntime and skl2onnx.
Gate the ONNX expected failure
python/cuml/cuml_accel_tests/test_onnx.py
The test records the installed ONNX Runtime version and applies the expected-failure marker only when the version is below 1.28.0.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: bdice, csadorf

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change to ONNX Runtime tests.
Description check ✅ Passed The description accurately explains the Python 3.14 test changes and ONNX Runtime version gating.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants