Skip to content

Remove xfail markers for cuml.accel examples - #8297

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
jinsolp:remove-xfail
Jun 26, 2026
Merged

Remove xfail markers for cuml.accel examples#8297
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
jinsolp:remove-xfail

Conversation

@jinsolp

@jinsolp jinsolp commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

This PR removes xfail markers that caused failures in nightly test: https://github.com/rapidsai/cuml/actions/runs/28229406180/job/83629207110

These tests pass now because of the following PRs merged yesterday:

@jinsolp jinsolp self-assigned this Jun 26, 2026
@jinsolp
jinsolp requested a review from a team as a code owner June 26, 2026 19:07
@jinsolp
jinsolp requested a review from divyegala June 26, 2026 19:07
@jinsolp jinsolp added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 26, 2026
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Jun 26, 2026
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 71283bbe-d2fc-4111-a268-aa94f248a48d

📥 Commits

Reviewing files that changed from the base of the PR and between ecb6469 and 5d7a6c9.

📒 Files selected for processing (1)
  • python/cuml/cuml_accel_tests/upstream/scikit-learn/xfail-examples.yaml
💤 Files with no reviewable changes (1)
  • python/cuml/cuml_accel_tests/upstream/scikit-learn/xfail-examples.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated test expectations for accelerated scikit-learn examples.
    • Removed several no-longer-needed known-issue entries, leaving only one remaining exception for a CUDA out-of-memory case during concurrent PCA testing.

Walkthrough

This PR removes three cuml.accel_bugs xfail entries from python/cuml/cuml_accel_tests/upstream/scikit-learn/xfail-examples.yaml, leaving the CUDA OOM PCA example in place and continuing directly to the existing plotly dependency reason.

Changes

xfail example cleanup

Layer / File(s) Summary
Trim cuml.accel_bugs entries
python/cuml/cuml_accel_tests/upstream/scikit-learn/xfail-examples.yaml
cuml.accel_bugs keeps the CUDA OOM PCA entry, and the native PCA crash, DecisionTreeClassifier treelite export, and pairwise_kernels entries are removed before the next plotly dependency reason.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

  • rapidsai/cuml issue 8180: The xfail cleanup touches the same sklearn example failure list and aligns with reducing remaining cuml.accel example failures.

Possibly related PRs

  • rapidsai/cuml#7960: Both changes update the same xfail-examples.yaml list used by the upstream scikit-learn example runner.
  • rapidsai/cuml#8280: Also edits xfail-examples.yaml and adjusts upstream sklearn failure expectations.
  • rapidsai/cuml#8290: Closely connected through the removal of the unhashable kernel object xfail case and related kernel/PCA fallback handling.

Suggested reviewers

  • betatim
  • csadorf
  • divyegala
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: removing xfail markers from cuml.accel examples.
Description check ✅ Passed The description matches the change by explaining that failing xfail markers were removed because the tests now pass.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jcrist jcrist left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jcrist

jcrist commented Jun 26, 2026

Copy link
Copy Markdown
Member

/merge

@rapids-bot
rapids-bot Bot merged commit 3fa74b2 into NVIDIA:main Jun 26, 2026
95 of 97 checks passed
@jinsolp
jinsolp deleted the remove-xfail branch June 26, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants