-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Rework join filter pushdown rewrites to leave hints and apply adaptively #23584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wence-
wants to merge
17
commits into
NVIDIA:main
Choose a base branch
from
wence-:wence/fea/polars-filter-hint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0f5b43a
Introduce PushdownFilterHint to represent semi joins in filter pushdown
wence- b99df37
Apply adaptive prefilters to direct join inputs
wence- 6bfe63a
Apply adaptive prefilters from external domains
wence- 4ea40b9
Better names
wence- fbd9d92
Separate prefilter eligibility from method selection
wence- 6e99daa
Extract reusable prefilter execution helpers
wence- a45112f
Expose reusable adaptive filtering utilities
wence- e0d48bf
Execute non-adjacent pushdown filter hints
wence- c1b9a2f
Share adaptive input sampling
wence- 283d7dc
Share adaptive prefilter execution
wence- 735340f
Tidy
wence- 30984cd
Filters not connected to their direct joins are free-standing
wence- 5065c2b
Ensure piecewise joins do not include prefilters
wence- 61fd0e5
Use asdict
wence- 1e81564
TableSizeStats offers distinct_count method
wence- e50c9d6
Refactor to introduce JoinPlanningState.create
wence- 09dfe8f
Update comment
wence- File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: the comment below describes why Union, Join, and Over need unbounded fanout.
Maybe it's just a person preference thing, but I'd prefer an
IR.needs_unbounaded_fanoutproperty / class variable, and then we can override that for specific IR nodes, and document the reasoning where we set the property.But this is fine too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whether one needs unbounded fanout is a property of the implementation choice, not the IR node per-se. So I prefer it here.