-
Notifications
You must be signed in to change notification settings - Fork 407
Add shared-ring realtime dispatch routing support #4712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cketcham2333
wants to merge
9
commits into
NVIDIA:main
Choose a base branch
from
cketcham2333:realtime_dispatch_from_kernel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
07777c7
[realtime] Add shared_ring_mode for cooperative HOST_LOOP + DEVICE_LOOP
cketcham2333 a287682
Cherry-pick #4529: Backtracking some of the changes of #4519
cketcham2333 6c2d99a
[realtime] Add routing_key sub-filter for GRAPH_LAUNCH workers
cketcham2333 ef72c8b
dispatch_kernel: add __threadfence_system() before rx_flags polling r…
cketcham2333 e3e0ba3
[realtime] Export the two dlsym entry points consumers actually need
cketcham2333 f74ff54
Merge remote-tracking branch 'upstream/main' into realtime_dispatch_f…
cketcham2333 d31272d
Merge remote-tracking branch 'upstream/main' into realtime_dispatch_f…
cketcham2333 d1f75b7
Fold shared-ring dispatcher test into host dispatcher test
cketcham2333 aacd480
clang format
cketcham2333 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,6 +39,15 @@ typedef struct { | |
| void *pre_launch_data; | ||
| void (*post_launch_fn)(void *user_data, void *slot_dev, cudaStream_t stream); | ||
| void *post_launch_data; | ||
| /// Optional sub-routing key for `function_id` collisions across workers. | ||
| /// When several workers share the same `function_id` but back different | ||
| /// captured graphs, the monitor uses (function_id, routing_key) to | ||
| /// disambiguate. The runtime routing key comes from the request | ||
| /// payload's first 8 bytes (arg0); a worker matches only if both | ||
| /// function_id and routing_key match. Set to 0 when sub-routing isn't | ||
| /// needed (the historical function_id-only match). | ||
| /// See proposals/cudaq_realtime_host_api.bs#host-path-graph-routing-key. | ||
| uint64_t routing_key; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Q: do we need to initialize this |
||
| } cudaq_host_dispatch_worker_t; | ||
|
|
||
| typedef struct { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits: line break (clang-format fallout, perhaps)