[python] Surface dem_from_kernel errors as RuntimeError#4676
Open
mitchdz wants to merge 2 commits into
Open
Conversation
…orting cudaq.dem_from_kernel runs the kernel under a dlopen'd `stim` analysis plugin. A non-Clifford gate makes Stim throw std::runtime_error from inside that plugin; on macOS the exception escapes uncaught at the binding boundary and the process aborts (SIGABRT / "Fatal Python error: Aborted"), crashing the test worker instead of raising in Python. Wrap the call in dem_from_kernel_impl and re-throw a fresh runtime_error owned by this module (with a catch-all fallback) so the error reliably surfaces as a Python RuntimeError on all platforms. Mirrors the catch-and-rethrow guard already used at other binding boundaries (e.g. runtime/cudaq/realtime.cpp). Fixes the macOS 'Python metapackage validation' failure on test_dem_from_kernel.py::test_non_clifford_raises. Signed-off-by: mdzurick <mitch_dz@hotmail.com>
CI Summary (
|
| Job | Result |
|---|---|
binaries |
⏩ skipped |
build_and_test |
✅ success |
config_devdeps |
✅ success |
config_source_build |
⏩ skipped |
config_wheeldeps |
✅ success |
devdeps |
✅ success |
docker_image |
⏩ skipped |
gen_code_coverage |
⏩ skipped |
metadata |
✅ success |
python_metapackages |
⏩ skipped |
python_wheels |
⏩ skipped |
source_build |
⏩ skipped |
wheeldeps |
✅ success |
⏩ Skipped jobs (7) — intentionally skipped on PR builds; run on merge_group / workflow_dispatch
| Job |
|---|
binaries |
config_source_build |
docker_image |
gen_code_coverage |
python_metapackages |
python_wheels |
source_build |
All sub-jobs (42) — every matrix leg, with links
| Job | Status | Link |
|---|---|---|
| Build and test (amd64, gcc12, openmpi) / Dev environment (Debug) | ✅ success | view |
| Build and test (amd64, gcc12, openmpi) / Dev environment (Python) | ✅ success | view |
| Build and test (amd64, llvm, openmpi) / Dev environment (Debug) | ✅ success | view |
| Build and test (amd64, llvm, openmpi) / Dev environment (Python) | ✅ success | view |
| Build and test (arm64, llvm, openmpi) / Dev environment (Debug) | ✅ success | view |
| Build and test (arm64, llvm, openmpi) / Dev environment (Python) | ✅ success | view |
| CI Summary | ❔ in_progress | view |
| Configure build (devdeps) | ✅ success | view |
| Configure build (source_build) | ⏩ skipped | view |
| Configure build (wheeldeps) | ✅ success | view |
| Create CUDA Quantum installer | ⏩ skipped | view |
| Create Docker images | ⏩ skipped | view |
| Create Python metapackages | ⏩ skipped | view |
| Create Python wheels | ⏩ skipped | view |
| Gen code coverage | ⏩ skipped | view |
| Load dependencies (amd64, gcc12) / Caching | ✅ success | view |
| Load dependencies (amd64, gcc12) / Finalize | ✅ success | view |
| Load dependencies (amd64, gcc12) / Metadata | ✅ success | view |
| Load dependencies (amd64, llvm) / Caching | ✅ success | view |
| Load dependencies (amd64, llvm) / Finalize | ✅ success | view |
| Load dependencies (amd64, llvm) / Metadata | ✅ success | view |
| Load dependencies (arm64, gcc12) / Caching | ✅ success | view |
| Load dependencies (arm64, gcc12) / Finalize | ✅ success | view |
| Load dependencies (arm64, gcc12) / Metadata | ✅ success | view |
| Load dependencies (arm64, llvm) / Caching | ✅ success | view |
| Load dependencies (arm64, llvm) / Finalize | ✅ success | view |
| Load dependencies (arm64, llvm) / Metadata | ✅ success | view |
| Load source build cache | ⏩ skipped | view |
| Load wheel dependencies (amd64, 12.6) / Caching | ✅ success | view |
| Load wheel dependencies (amd64, 12.6) / Finalize | ✅ success | view |
| Load wheel dependencies (amd64, 12.6) / Metadata | ✅ success | view |
| Load wheel dependencies (amd64, 13.0) / Caching | ✅ success | view |
| Load wheel dependencies (amd64, 13.0) / Finalize | ✅ success | view |
| Load wheel dependencies (amd64, 13.0) / Metadata | ✅ success | view |
| Load wheel dependencies (arm64, 12.6) / Caching | ✅ success | view |
| Load wheel dependencies (arm64, 12.6) / Finalize | ✅ success | view |
| Load wheel dependencies (arm64, 12.6) / Metadata | ✅ success | view |
| Load wheel dependencies (arm64, 13.0) / Caching | ✅ success | view |
| Load wheel dependencies (arm64, 13.0) / Finalize | ✅ success | view |
| Load wheel dependencies (arm64, 13.0) / Metadata | ✅ success | view |
| Prepare cache clean-up | ❔ in_progress | view |
| Retrieve PR info | ✅ success | view |
✅ Required checks (6/6) — declared in .github/required-checks.yml for push
| Required check | Status | Link |
|---|---|---|
| Build and test (amd64, llvm, openmpi) / Dev environment (Debug) | ✅ success | view |
| Build and test (amd64, llvm, openmpi) / Dev environment (Python) | ✅ success | view |
| Build and test (arm64, llvm, openmpi) / Dev environment (Debug) | ✅ success | view |
| Build and test (arm64, llvm, openmpi) / Dev environment (Python) | ✅ success | view |
| Build and test (amd64, gcc12, openmpi) / Dev environment (Debug) | ✅ success | view |
| Build and test (amd64, gcc12, openmpi) / Dev environment (Python) | ✅ success | view |
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
Review follow-up: the catch-all guard added previously also intercepted nanobind::python_error (which derives from std::runtime_error) thrown by marshal_and_launch_module during argument marshalling/launch, flattening a real Python error to a generic RuntimeError (losing its type/traceback) or mislabeling it as a Clifford error. Catch nanobind::python_error first and re-throw it unchanged so genuine Python exceptions propagate intact; only foreign C++ exceptions fall through to the RuntimeError translation. Signed-off-by: mdzurick <mitch_dz@hotmail.com>
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cudaq.dem_from_kernel runs the kernel under a dlopen'd
stimanalysis plugin. A non-Clifford gate makes Stim throwstd::runtime_errorfrom inside that plugin; on macOS the exception escapes uncaught at the binding boundary and the process aborts (SIGABRT / "Fatal Python error: Aborted"), crashing the test worker instead of raising in Python.Wrap the call in dem_from_kernel_impl and re-throw a fresh runtime_error owned by this module (with a catch-all fallback) so the error reliably surfaces as a Python RuntimeError on all platforms. Mirrors the catch-and-rethrow guard already used at other binding boundaries (e.g. runtime/cudaq/realtime.cpp).
Fixes the macOS 'Python metapackage validation' failure on test_dem_from_kernel.py::test_non_clifford_raises.
See https://github.com/NVIDIA/cuda-quantum/actions/runs/26986910544/job/79748077581