Skip to content

Make header dependencies explicit. #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romerojosh merged 1 commit into from
Apr 29, 2026
Merged

Make header dependencies explicit. #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/cudecomp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
#ifndef CUDECOMP_H
#define CUDECOMP_H

#include <stdbool.h>
#include <stdint.h>

#include <cuda_runtime.h>
#include <mpi.h>

Expand All @@ -35,9 +38,6 @@
extern "C" {
#endif

#include <stdbool.h>
#include <stdint.h>

/**
* @brief This enum lists the different available transpose backend options.
*/
Expand Down
2 changes: 2 additions & 0 deletions include/internal/checks.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@
#define CUDECOMP_CHECKS_H

#include <cstdio>
#include <cstdlib>
#include <iostream>
#include <sstream>
#include <string>

#include <cuda.h>
Expand Down
8 changes: 8 additions & 0 deletions include/internal/comm_routines.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,16 @@
#ifndef COMM_ROUTINES_H
#define COMM_ROUTINES_H

#include <array>
#include <cstddef>
#include <cstdint>
#include <cstdio>
#include <limits>
#include <sstream>
#include <string>
#include <vector>

#include <cuda/std/complex>
#include <cuda_runtime.h>
#include <mpi.h>
#include <nccl.h>
Expand Down
6 changes: 6 additions & 0 deletions include/internal/common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,26 @@
#ifndef CUDECOMP_COMMON_H
#define CUDECOMP_COMMON_H

#include <algorithm>
#include <array>
#include <complex>
#include <cstddef>
#include <cstdint>
#include <functional>
#include <map>
#include <memory>
#include <sstream>
#include <string>
#include <tuple>
#include <unordered_map>
#include <utility>
#include <vector>

#include <cuda_runtime.h>
#include <cutensor.h>
#include <mpi.h>
#include <nccl.h>
#include <nvml.h>
#ifdef ENABLE_NVSHMEM
#include <nvshmem.h>
#include <nvshmemx.h>
Expand Down
2 changes: 2 additions & 0 deletions include/internal/cuda_wrap.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
#ifndef CUDECOMP_CUDA_WRAP_H
#define CUDECOMP_CUDA_WRAP_H

#include <cuda_runtime.h>

#if CUDART_VERSION >= 11030
#include <cudaTypedefs.h>
#endif
Expand Down
2 changes: 2 additions & 0 deletions include/internal/cudecomp_kernels.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
#define CUDECOMP_KERNELS_CUH

#include <algorithm>
#include <cstddef>
#include <cstdint>

#ifdef ENABLE_NVSHMEM
#include <nvshmem.h>
Expand Down
3 changes: 3 additions & 0 deletions include/internal/cudecomp_kernels.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
#ifndef CUDECOMP_KERNELS_H
#define CUDECOMP_KERNELS_H

#include <cstddef>
#include <cstdint>

#include <cuda/std/complex>

#include "internal/common.h"
Expand Down
4 changes: 4 additions & 0 deletions include/internal/halo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@
#ifndef HALO_H
#define HALO_H

#include <algorithm>
#include <array>
#include <cstddef>
#include <cstdint>
#include <sstream>
#include <vector>

#include <cuda_runtime.h>
Expand Down
1 change: 1 addition & 0 deletions include/internal/hashes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#define CUDECOMP_HASHES_H

#include <array>
#include <cstddef>
#include <functional>
#include <tuple>
#include <utility>
Expand Down
1 change: 1 addition & 0 deletions include/internal/nvtx.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#ifndef CUDECOMP_NVTX_H
#define CUDECOMP_NVTX_H

#include <functional>
#include <string>

#ifdef ENABLE_NVTX
Expand Down
1 change: 1 addition & 0 deletions include/internal/performance.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#define CUDECOMP_PERFORMANCE_H

#include <array>
#include <cstdint>
#include <string>
#include <tuple>
#include <unordered_map>
Expand Down
3 changes: 3 additions & 0 deletions include/internal/transpose.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,11 @@
#ifndef TRANSPOSE_H
#define TRANSPOSE_H

#include <algorithm>
#include <array>
#include <cstddef>
#include <cstdint>
#include <limits>
#include <vector>

#include <cuda/std/complex>
Expand Down
4 changes: 4 additions & 0 deletions src/autotune.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@

#include <algorithm>
#include <array>
#include <cmath>
#include <cstddef>
#include <cstdint>
#include <cstdio>
#include <numeric>
#include <string>
#include <vector>
Expand Down
7 changes: 7 additions & 0 deletions src/cudecomp.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,19 @@
*/

#include <algorithm>
#include <array>
#include <cmath>
#include <cstddef>
#include <cstdint>
#include <cstdio>
#include <cstdlib>
#include <cstring>
#include <iostream>
#include <numeric>
#include <set>
#include <string>
#include <unordered_map>
#include <utility>
#include <vector>

#include <cuda.h>
Expand Down
3 changes: 3 additions & 0 deletions src/cudecomp_kernels_rdc.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
* limitations under the License.
*/

#include <algorithm>
#include <cstdint>

#include <cuda/std/complex>

#include "internal/checks.h"
Expand Down
7 changes: 7 additions & 0 deletions src/performance.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@
*/

#include <algorithm>
#include <array>
#include <cstddef>
#include <cstdint>
#include <cstdio>
#include <cstdlib>
#include <filesystem>
#include <fstream>
Expand All @@ -25,6 +29,9 @@
#include <numeric>
#include <sstream>
#include <string>
#include <tuple>
#include <utility>
#include <vector>

#include <mpi.h>

Expand Down
Loading