Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions conf/experimental/ai_dynamo/test/sglang.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ test_template_name = "AIDynamo"
extra_container_mounts = ["/run/udev:/run/udev", "/tmp:/tmp"]

[cmd_args]
docker_image_url = "nvcr.io/nvidia/ai-dynamo/sglang-runtime:0.9.0"
docker_image_url = "nvcr.io/nvidia/ai-dynamo/sglang-runtime:1.0.0"
workloads = "genai_perf.sh"

[cmd_args.dynamo]
Expand All @@ -32,7 +32,7 @@ workloads = "genai_perf.sh"
num-nodes = 1
cmd = 'python3 -m dynamo.sglang'
extra-args = "--trust-remote-code --skip-tokenizer-init --enable-metrics"
worker-initialized-regex = 'register._register_llm_with_runtime_config:.Successfully.registered.LLM.with.runtime.config'
worker-initialized-regex = 'register._register_model_with_runtime_config:.Successfully.registered.LLM.with.runtime.config'

[cmd_args.dynamo.prefill_worker.args]
page-size = 16
Expand All @@ -48,7 +48,7 @@ workloads = "genai_perf.sh"
num-nodes = 1
cmd = 'python3 -m dynamo.sglang'
extra-args = "--trust-remote-code --skip-tokenizer-init --enable-metrics"
worker-initialized-regex = 'register._register_llm_with_runtime_config:.Successfully.registered.LLM.with.runtime.config'
worker-initialized-regex = 'register._register_model_with_runtime_config:.Successfully.registered.LLM.with.runtime.config'

[cmd_args.dynamo.decode_worker.args]
page-size = 16
Expand Down Expand Up @@ -79,6 +79,7 @@ workloads = "genai_perf.sh"

[cmd_args.genai_perf]
cmd = "genai-perf profile"
client-docker-image-url = "nvcr.io/nvidia/tritonserver:25.03-py3-sdk"
extra-args = "--streaming --verbose -- -v --async"

[cmd_args.genai_perf.args]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ name = "dynamo_sglang"

[[Tests]]
id = "sglang-Qwen3-0.6B"
test_name = "sglang-Qwen3-0.6B"
test_name = "sglang"
time_limit = "00:20:00"

[Tests.cmd_args]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
name = "dynamo_vllm_kvbm"

[[Tests]]
id = "vLLM-Qwen3-0.6B"
id = "vLLM"
test_name = "vLLM"
time_limit = "20:00:00"

Expand Down
4 changes: 2 additions & 2 deletions conf/experimental/ai_dynamo/test_scenario/vllm_slurm.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ job_status_check = false

[[Tests]]
id = "test.disagg.single-node"
test_name = "vLLM-Qwen3-0.6B"
test_name = "vLLM"
time_limit = "00:10:00"

[Tests.cmd_args]
Expand All @@ -38,7 +38,7 @@ time_limit = "00:10:00"

[[Tests]]
id = "test.disagg.multinode"
test_name = "vLLM-Qwen3-0.6B"
test_name = "vLLM"
time_limit = "00:10:00"

[Tests.cmd_args]
Expand Down
10 changes: 9 additions & 1 deletion src/cloudai/workloads/ai_dynamo/ai_dynamo.py
Original file line number Diff line number Diff line change
Expand Up @@ -276,10 +276,18 @@ class GenAIPerf(Workload):
name: str = "genai_perf"
cmd: str = "genai-perf profile"
script: File = File(Path(__file__).parent.parent / "ai_dynamo/genai_perf.sh")
client_docker_image_url: str | None = Field(
default=None,
serialization_alias="client-docker-image-url",
validation_alias=AliasChoices("client-docker-image-url", "client_docker_image_url"),
)

@property
def installables(self) -> list[Installable]:
return [self.script]
result: list[Installable] = [self.script]
if self.client_docker_image_url:
result.append(DockerImage(url=self.client_docker_image_url))
return result


class Constraints(BaseModel):
Expand Down
9 changes: 8 additions & 1 deletion src/cloudai/workloads/ai_dynamo/ai_dynamo.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ DONE_MARKER="./success-marker.txt"
FATAL_ERROR_MARKER="./failure-marker.txt"
NODE_ROLES_FILE="node_roles.log"
TEST_USER="$USER"
WAIT_FOR_EXTERNAL_WORKLOAD="false"

export DYN_SDK_DISABLE_ANSI_LOGGING=1
export VLLM_DISABLE_COLORED_OUTPUT=1
Expand Down Expand Up @@ -177,6 +178,8 @@ _parse_cli_pairs() {
FATAL_ERROR_MARKER="$2" ;;
--success-marker)
DONE_MARKER="$2" ;;
--wait-for-external-workload)
WAIT_FOR_EXTERNAL_WORKLOAD="$2" ;;
esac
shift; shift;
done
Expand Down Expand Up @@ -1078,7 +1081,11 @@ function main()

sleep 10

launch_workloads &
if [[ "$WAIT_FOR_EXTERNAL_WORKLOAD" == "true" ]]; then
log "Waiting for external workload to complete"
else
launch_workloads &
fi
fi

wait_for_frontend_marker
Expand Down
139 changes: 137 additions & 2 deletions src/cloudai/workloads/ai_dynamo/slurm_command_gen_strategy.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

from pydantic import BaseModel, TypeAdapter, ValidationError

from cloudai.core import File, GitRepo
from cloudai.core import DockerImage, File, GitRepo
from cloudai.systems.slurm import SlurmCommandGenStrategy

from .ai_dynamo import AIDynamoTestDefinition
Expand Down Expand Up @@ -84,7 +84,7 @@ def _get_nested_toml_args(self, base_model: BaseModel, prefix: str) -> List[str]

return result

def _gen_script_args(self, td: AIDynamoTestDefinition) -> List[str]:
def _gen_script_args(self, td: AIDynamoTestDefinition, wait_for_external_workload: bool = False) -> List[str]:
assert td.repo.installed_path
args = [
"--user $USER",
Expand All @@ -97,6 +97,9 @@ def _gen_script_args(self, td: AIDynamoTestDefinition) -> List[str]:
f"--success-marker {self.CONTAINER_MOUNT_OUTPUT}/{td.success_marker}",
]

if wait_for_external_workload:
args.append("--wait-for-external-workload true")

if td.cmd_args.storage_cache_dir:
args.append(f"--storage-cache-dir {td.cmd_args.storage_cache_dir}")

Expand All @@ -120,6 +123,15 @@ def _gen_script_args(self, td: AIDynamoTestDefinition) -> List[str]:

return args

def _client_image_path(self, td: AIDynamoTestDefinition) -> str | None:
client_image_url = td.cmd_args.genai_perf.client_docker_image_url
if not client_image_url:
return None
client_image = DockerImage(url=client_image_url)
if client_image.installed_path:
return str(client_image.installed_path)
return None

def _gen_srun_command(self) -> str:
td = cast(AIDynamoTestDefinition, self.test_run.test)
num_nodes, node_list = self.get_cached_nodes_spec()
Expand All @@ -142,6 +154,129 @@ def _gen_srun_command(self) -> str:
srun_cmd.extend(self._gen_script_args(td))
return " \\\n ".join(srun_cmd) + "\n"

def _gen_service_srun_command(self) -> str:
td = cast(AIDynamoTestDefinition, self.test_run.test)
num_nodes, node_list = self.get_cached_nodes_spec()
out_dir = str(self.test_run.output_path.absolute())

srun_cmd = self.gen_srun_prefix()
srun_cmd.extend(
[
f"--nodes={num_nodes}",
*([] if not node_list else [f"--nodelist={','.join(node_list)}"]),
f"--ntasks={num_nodes}",
"--ntasks-per-node=1",
f"--output={out_dir}/node-%n-stdout.txt",
f"--error={out_dir}/node-%n-stderr.txt",
"bash",
f"{self.CONTAINER_MOUNT_INSTALL}/{td.script.src.name}",
]
)
srun_cmd.extend(self._gen_script_args(td, wait_for_external_workload=True))
return " ".join(srun_cmd)

def _client_container_mounts(self, td: AIDynamoTestDefinition) -> list[str]:
mounts = [
f"{self.test_run.output_path.absolute()}:{self.CONTAINER_MOUNT_OUTPUT}",
f"{self.system.install_path.absolute()}:{self.CONTAINER_MOUNT_INSTALL}",
f"{self.test_run.output_path.absolute()}",
*td.extra_container_mounts,
f"{self.system.hf_home_path.absolute()}:{self.CONTAINER_MOUNT_HF_HOME}",
]

if td.cmd_args.storage_cache_dir:
mounts.append(f"{td.cmd_args.storage_cache_dir}:{td.cmd_args.storage_cache_dir}")

return mounts

def _gen_client_srun_prefix(self, image_path: str) -> list[str]:
srun_cmd = ["srun", "--export=ALL", f"--mpi={self.system.mpi}"]
mounts = self._client_container_mounts(cast(AIDynamoTestDefinition, self.test_run.test))
srun_cmd.append(f"--container-image={image_path}")
srun_cmd.append(f"--container-mounts={','.join(mounts)}")
if not self.system.container_mount_home:
srun_cmd.append("--no-container-mount-home")
if self.system.extra_srun_args:
srun_cmd.append(self.system.extra_srun_args)
if self.test_run.extra_srun_args:
srun_cmd.append(self.test_run.extra_srun_args)
return srun_cmd

def _gen_external_benchmark_command(self, image_path: str) -> str:
td = cast(AIDynamoTestDefinition, self.test_run.test)
out_dir = str(self.test_run.output_path.absolute())

srun_cmd = self._gen_client_srun_prefix(image_path)
srun_cmd.extend(
[
"--overlap",
"--nodes=1",
"--nodelist=$SLURM_JOB_MASTER_NODE",
"--ntasks=1",
"--ntasks-per-node=1",
f"--output={out_dir}/genai-perf-stdout.txt",
f"--error={out_dir}/genai-perf-stderr.txt",
"bash",
f"{self.CONTAINER_MOUNT_INSTALL}/{td.cmd_args.genai_perf.script.src.name}",
f"--result-dir {self.CONTAINER_MOUNT_OUTPUT}",
f'--model "{td.cmd_args.dynamo.model}"',
'--url "http://$SLURM_JOB_MASTER_NODE"',
f'--port "{td.cmd_args.dynamo.port}"',
f'--endpoint "{td.cmd_args.dynamo.endpoint}"',
f'--gpus-per-node "{self.system.gpus_per_node or 1}"',
f'--report-name "{td.cmd_args.genai_perf.report_name}"',
f'--cmd "{td.cmd_args.genai_perf.cmd}"',
]
)
if td.cmd_args.genai_perf.extra_args:
extra_args = td.cmd_args.genai_perf.extra_args
if isinstance(extra_args, list):
extra_args = " ".join(str(arg) for arg in extra_args)
srun_cmd.append(f'--extra-args "{extra_args}"')

srun_cmd.append("--")
srun_cmd.extend(self._get_toml_args(td.cmd_args.genai_perf.args, "--"))

return " ".join(srun_cmd)

def gen_exec_command(self) -> str:
td = cast(AIDynamoTestDefinition, self.test_run.test)
client_image_path = self._client_image_path(td)
if not client_image_path:
return super().gen_exec_command()

service_cmd = self._gen_service_srun_command()
benchmark_cmd = self._gen_external_benchmark_command(client_image_path)
success_marker = f"{self.test_run.output_path.absolute()}/{td.success_marker}"

full_command = "\n".join(
[
'if [ -z "$SLURM_JOB_MASTER_NODE" ]; then',
' echo "SLURM_JOB_MASTER_NODE is not set" >&2',
" exit 1",
"fi",
f"{service_cmd} &",
"SERVICE_PID=$!",
"BENCH_RC=0",
"for _ in $(seq 1 120); do",
f' if curl -sf "http://$SLURM_JOB_MASTER_NODE:{td.cmd_args.dynamo.port}/v1/models" >/dev/null 2>&1; then', # noqa: E501
" break",
" fi",
" sleep 5",
"done",
f'if ! curl -sf "http://$SLURM_JOB_MASTER_NODE:{td.cmd_args.dynamo.port}/v1/models" >/dev/null 2>&1; then', # noqa: E501
" BENCH_RC=1",
"else",
f" {benchmark_cmd} || BENCH_RC=$?",
"fi",
f'touch "{success_marker}"',
"wait $SERVICE_PID || true",
"exit $BENCH_RC",
]
)

return self._write_sbatch_script(full_command)

def _validate_worker_nodes(
self, node_list: list[str], worker_nodes: str | None, num_nodes: int, worker_type: str
) -> None:
Expand Down
34 changes: 34 additions & 0 deletions tests/workloads/ai_dynamo/test_command_gen_strategy_slurm.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,3 +148,37 @@ def test_dynamo_cmd(
) -> None:
result = strategy.gen_dynamo_cmd(module, Path(config))
assert result.strip() == expected


def test_gen_exec_command_with_external_genai_perf_client(
slurm_system: SlurmSystem, tmp_path: Path, cmd_args: AIDynamoCmdArgs
) -> None:
dynamo_repo_path = tmp_path / "dynamo_repo"
dynamo_repo_path.mkdir()

cmd_args.genai_perf.client_docker_image_url = "nvcr.io/nvidia/tritonserver:25.03-py3-sdk"

tdef = AIDynamoTestDefinition(
name="test",
description="desc",
test_template_name="template",
cmd_args=cmd_args,
repo=GitRepo(
url="https://github.com/ai-dynamo/dynamo.git",
commit="f7e468c7e8ff0d1426db987564e60572167e8464",
installed_path=dynamo_repo_path,
),
)

tr = TestRun(name="run", test=tdef, nodes=["n0", "n1"], num_nodes=2, output_path=tmp_path)
strategy = AIDynamoSlurmCommandGenStrategy(slurm_system, tr)

command = strategy.gen_exec_command()
script_path = Path(command.removeprefix("sbatch ").strip())
content = script_path.read_text()

assert "--wait-for-external-workload true" in content
assert "genai-perf-stdout.txt" in content
assert "genai-perf-stderr.txt" in content
assert "tritonserver:25.03-py3-sdk" in content
assert "/v1/models" in content
Loading