fix(pe3): require a credential-store access shape, not a bare noun - #424
fix(pe3): require a credential-store access shape, not a bare noun#424rodboev wants to merge 10 commits into
Conversation
c74ba56 to
cbcf954
Compare
rng1995
left a comment
There was a problem hiding this comment.
[SkillSpector Review]
Requesting changes for a remaining PE3 false-positive path. The new nearby-word test treats descriptive access terminology as an access action, so ordinary prose can still become a high-severity credential-access finding. Please tighten the relationship between the store noun and an actual read/retrieve/mutation instruction and add a descriptive keyring access policy-style regression.
|
[SkillSpector Maintainer Ping] @rodboev, please address the outstanding PE3 review feedback on this PR. Descriptive prose such as The branch is currently behind |
Signed-off-by: Rod Boev <rod.boev@gmail.com>
Signed-off-by: Rod Boev <rod.boev@gmail.com>
Signed-off-by: Rod Boev <rod.boev@gmail.com>
Signed-off-by: Rod Boev <rod.boev@gmail.com>
Signed-off-by: Rod Boev <rod.boev@gmail.com>
Signed-off-by: Rod Boev <rod.boev@gmail.com>
Signed-off-by: Rod Boev <rod.boev@gmail.com>
Signed-off-by: Rod Boev <rod.boev@gmail.com>
Signed-off-by: Rod Boev <rod.boev@gmail.com>
Signed-off-by: Rod Boev <rod.boev@gmail.com>
5e7347d to
b0b3752
Compare
|
Powered by Codex: PR council review result. This is a triage signal, not a maintainer approval.
|
Summary
PE3 now requires a credential-store operation tied to the matched keyring or keychain noun in Markdown and text prose. Bare descriptive nouns remain clean; actionable reads, writes, mutations, API or CLI commands, fenced content, and code or configuration remain detected.
Root cause
The vocabulary pattern flagged credential-store nouns without requiring an access shape. A nearby-word qualifier could also let benign reading text suppress a later operation.
Diff Notes
Scope
Limited to PE3 credential-store qualification, shared fence and line handling, and focused regressions. Other PE rules and finding, report, severity, score, recommendation, suppression, and SARIF contracts are unchanged.
Closes #396