Fix project site 404 rendering - #16
Merged
Merged
Conversation
Signed-off-by: Johnny Greco <jogreco@nvidia.com>
Documentation previewThe preview has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Zensical renders its special
404.htmlwithout a normal page URL context. Extending the main theme therefore emitted domain-root paths such as/assets/..., while this project is hosted under/OpenShell-Research/. Those requests returned 404, leaving raw theme controls and oversized broken image placeholders.Validation
python3 tests/test_render_dev_notes.py— 11 passedpython3 tests/test_docs_404.py— source checks passedscripts/build-docs.sh— clean strict build and rendered 404 regression checks passedactionlintfor both preview workflows