Skip to content

Fix project site 404 rendering - #16

Merged
johnnygreco merged 1 commit into
mainfrom
johnny/hotfix/standalone-404
Jul 20, 2026
Merged

Fix project site 404 rendering#16
johnnygreco merged 1 commit into
mainfrom
johnny/hotfix/standalone-404

Conversation

@johnnygreco

Copy link
Copy Markdown
Collaborator

Summary

  • replace the theme-dependent 404 with a self-contained responsive page
  • inline the OpenShell mark and all light/dark styles so missing paths make no asset requests
  • preserve distinct messages for ordinary missing pages and expired PR previews
  • add a rendered-output regression test to the strict docs build

Root cause

Zensical renders its special 404.html without a normal page URL context. Extending the main theme therefore emitted domain-root paths such as /assets/..., while this project is hosted under /OpenShell-Research/. Those requests returned 404, leaving raw theme controls and oversized broken image placeholders.

Validation

  • python3 tests/test_render_dev_notes.py — 11 passed
  • python3 tests/test_docs_404.py — source checks passed
  • scripts/build-docs.sh — clean strict build and rendered 404 regression checks passed
  • YAML parsing and actionlint for both preview workflows
  • Node execution checks for general and expired-preview path behavior
  • local missing-preview route served the standalone generated page

Signed-off-by: Johnny Greco <jogreco@nvidia.com>
@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown

Documentation preview

The preview has been removed.

@johnnygreco
johnnygreco merged commit 628ff3f into main Jul 20, 2026
7 checks passed
@johnnygreco
johnnygreco deleted the johnny/hotfix/standalone-404 branch July 20, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant