-
Notifications
You must be signed in to change notification settings - Fork 324
remove 26.05 RC doc references #2213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
2782fe7
7b0dc60
72b5f78
df96200
b1f0a98
cb0b658
0e19edf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -44,7 +44,7 @@ For **local GPU inference** (Nemotron models running on your GPU), install with | |||||
| ```bash | ||||||
| uv venv retriever --python 3.12 | ||||||
| source retriever/bin/activate | ||||||
| uv pip install "nemo-retriever[local]==26.05-RC1" | ||||||
| uv pip install "nemo-retriever[local]" | ||||||
| ``` | ||||||
|
|
||||||
| Install matching **ingestion client** and **ingestion runtime** wheels at the same version when your workflow expects them (see the [NeMo Retriever Library prerequisites](https://docs.nvidia.com/nemo/retriever/latest/extraction/overview/) for the exact PyPI coordinates for your release). | ||||||
|
|
@@ -55,7 +55,7 @@ For **remote NIM inference only** (no local GPU required), the base package is s | |||||
| uv python install 3.12 | ||||||
| uv venv retriever --python 3.12 | ||||||
| source retriever/bin/activate | ||||||
| uv pip install nemo-retriever==26.05-RC1 | ||||||
| uv pip install nemo-retriever | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: nemo_retriever/README.md
Line: 58
Comment:
Same missing version pin as the `[local]` extra above — the base package install should also be pinned to the GA release so it is consistent with the surrounding version guidance.
```suggestion
uv pip install nemo-retriever==26.5.0
```
How can I resolve this? If you propose a fix, please make it concise. |
||||||
| ``` | ||||||
|
|
||||||
| Install matching **ingestion client** and **ingestion runtime** wheels at the same version when your workflow expects them (see the [NeMo Retriever Library prerequisites](https://docs.nvidia.com/nemo/retriever/latest/extraction/overview/) for the exact PyPI coordinates for your release). | ||||||
|
|
@@ -65,7 +65,7 @@ This creates a dedicated Python environment and installs the `nemo-retriever` Py | |||||
| If your PDF pipeline uses `extract_method="nemotron_parse"`, install the Nemotron Parse client dependencies with the `nemotron-parse` extra: | ||||||
|
|
||||||
| ```bash | ||||||
| uv pip install "nemo-retriever[nemotron-parse]==26.05-RC1" | ||||||
| uv pip install "nemo-retriever[nemotron-parse]" | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: nemo_retriever/README.md
Line: 68
Comment:
Same missing version pin as the two commands above — the `[nemotron-parse]` extra should be pinned to `26.5.0` for the same reasons.
```suggestion
uv pip install "nemo-retriever[nemotron-parse]==26.5.0"
```
How can I resolve this? If you propose a fix, please make it concise. |
||||||
| ``` | ||||||
|
|
||||||
| For local GPU inference with Nemotron Parse, combine the extras as `nemo-retriever[local,nemotron-parse]`. | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
26.5.0release, but the diff removes the version specifiers entirely. Without a pin, users running these commands will install whatever the current latest version ofnemo-retrieveris on PyPI, which may not match the documentation or the companionnv-ingest-client/runtime wheels that the following paragraph instructs them to install "at the same version". This breaks the documented reproducibility guarantee and could cause compatibility mismatches as future releases ship.Prompt To Fix With AI