Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ SPDX-License-Identifier: Apache-2.0

**Important: The default branch is main, which tracks active development and may be ahead of the latest supported release.**

For the latest release line use the [26.05 branch](https://github.com/NVIDIA/NeMo-Retriever/tree/26.05) (RC builds are tagged `26.05-RC1`, `26.05-RC2`, …). The previous stable line is [26.03](https://github.com/NVIDIA/NeMo-Retriever/tree/26.03).
For the latest supported release, use the [26.05 branch](https://github.com/NVIDIA/NeMo-Retriever/tree/26.05) (GA PyPI and Helm chart version `26.5.0`). The previous stable line is [26.03](https://github.com/NVIDIA/NeMo-Retriever/tree/26.03).

See the corresponding [NeMo Retriever Library documentation](https://docs.nvidia.com/nemo/retriever/latest/extraction/overview/).

Expand Down
6 changes: 3 additions & 3 deletions nemo_retriever/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ For **local GPU inference** (Nemotron models running on your GPU), install with
```bash
uv venv retriever --python 3.12
source retriever/bin/activate
uv pip install "nemo-retriever[local]==26.05-RC1"
uv pip install "nemo-retriever[local]"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 The PR description says these commands should be pinned to the GA 26.5.0 release, but the diff removes the version specifiers entirely. Without a pin, users running these commands will install whatever the current latest version of nemo-retriever is on PyPI, which may not match the documentation or the companion nv-ingest-client/runtime wheels that the following paragraph instructs them to install "at the same version". This breaks the documented reproducibility guarantee and could cause compatibility mismatches as future releases ship.

Suggested change
uv pip install "nemo-retriever[local]"
uv pip install "nemo-retriever[local]==26.5.0"
Prompt To Fix With AI
This is a comment left during a code review.
Path: nemo_retriever/README.md
Line: 47

Comment:
The PR description says these commands should be pinned to the GA `26.5.0` release, but the diff removes the version specifiers entirely. Without a pin, users running these commands will install whatever the current latest version of `nemo-retriever` is on PyPI, which may not match the documentation or the companion `nv-ingest-client`/runtime wheels that the following paragraph instructs them to install "at the same version". This breaks the documented reproducibility guarantee and could cause compatibility mismatches as future releases ship.

```suggestion
uv pip install "nemo-retriever[local]==26.5.0"
```

How can I resolve this? If you propose a fix, please make it concise.

```

Install matching **ingestion client** and **ingestion runtime** wheels at the same version when your workflow expects them (see the [NeMo Retriever Library prerequisites](https://docs.nvidia.com/nemo/retriever/latest/extraction/overview/) for the exact PyPI coordinates for your release).
Expand All @@ -55,7 +55,7 @@ For **remote NIM inference only** (no local GPU required), the base package is s
uv python install 3.12
uv venv retriever --python 3.12
source retriever/bin/activate
uv pip install nemo-retriever==26.05-RC1
uv pip install nemo-retriever

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Same missing version pin as the [local] extra above — the base package install should also be pinned to the GA release so it is consistent with the surrounding version guidance.

Suggested change
uv pip install nemo-retriever
uv pip install nemo-retriever==26.5.0
Prompt To Fix With AI
This is a comment left during a code review.
Path: nemo_retriever/README.md
Line: 58

Comment:
Same missing version pin as the `[local]` extra above — the base package install should also be pinned to the GA release so it is consistent with the surrounding version guidance.

```suggestion
uv pip install nemo-retriever==26.5.0
```

How can I resolve this? If you propose a fix, please make it concise.

```

Install matching **ingestion client** and **ingestion runtime** wheels at the same version when your workflow expects them (see the [NeMo Retriever Library prerequisites](https://docs.nvidia.com/nemo/retriever/latest/extraction/overview/) for the exact PyPI coordinates for your release).
Expand All @@ -65,7 +65,7 @@ This creates a dedicated Python environment and installs the `nemo-retriever` Py
If your PDF pipeline uses `extract_method="nemotron_parse"`, install the Nemotron Parse client dependencies with the `nemotron-parse` extra:

```bash
uv pip install "nemo-retriever[nemotron-parse]==26.05-RC1"
uv pip install "nemo-retriever[nemotron-parse]"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Same missing version pin as the two commands above — the [nemotron-parse] extra should be pinned to 26.5.0 for the same reasons.

Suggested change
uv pip install "nemo-retriever[nemotron-parse]"
uv pip install "nemo-retriever[nemotron-parse]==26.5.0"
Prompt To Fix With AI
This is a comment left during a code review.
Path: nemo_retriever/README.md
Line: 68

Comment:
Same missing version pin as the two commands above — the `[nemotron-parse]` extra should be pinned to `26.5.0` for the same reasons.

```suggestion
uv pip install "nemo-retriever[nemotron-parse]==26.5.0"
```

How can I resolve this? If you propose a fix, please make it concise.

```

For local GPU inference with Nemotron Parse, combine the extras as `nemo-retriever[local,nemotron-parse]`.
Expand Down
2 changes: 1 addition & 1 deletion nemo_retriever/helm/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1093,7 +1093,7 @@ See [Deployment options — Air-gapped and disconnected deployment](https://docs
### Container images to mirror (26.05 chart defaults)

Verify tags on the Git branch or tag you ship (for example `26.05` or
`26.05-RC1`). Defaults below match
`26.5.0`). Defaults below match
[`values.yaml`](./values.yaml) on the current chart.

| Role | `nimOperator` key | Default image (`repository:tag`) |
Expand Down
Loading