fix: enable TLS for OTLP HTTP export#92
Merged
Merged
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
WalkthroughSingle-line dependency feature update in ChangesDependency Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
AjayThorve
approved these changes
May 13, 2026
bbednarski9
approved these changes
May 13, 2026
bbednarski9
left a comment
There was a problem hiding this comment.
Double checked that we do not add any new deps with this. LGTM
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Enable TLS support for NeMo Flow's native OTLP/HTTP exporter so direct HTTPS trace endpoints, including internal platform backed Datadog ingestion, work without routing through a local OpenTelemetry collector.
Details
reqwest-rustlsfeature to the nativeopentelemetry-otlpdependency.Validation:
cargo tree -p nemo-flow -e features -i reqwest --features otel --target x86_64-apple-darwinconfirmsreqwest/rustls-tls-native-rootsis enabled.cargo test -p nemo-flow --features otel observability::otel::tests -- --nocaptureWhere should the reviewer start?
N/A
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit