patchscan: fix PR body quoting and provenance checks#399
Closed
nirmoy wants to merge 3 commits into
Closed
Conversation
Two improvements addressing false-positive failures on tracked-branch PRs: 1. Launchpad bug link: drop the requirement that the URL appear on a line prefixed with 'BugLink:' or 'LP:'. The check now only ensures a https://bugs.launchpad.net/... URL exists somewhere in the PR body. Avoids false negatives when authors paste the link in prose. 2. UBUNTU-local commits (e.g. 'UBUNTU: [Config] ...', 'UBUNTU: [Packaging] ...', 'UBUNTU: SAUCE: ...') have no upstream equivalent and previously triggered R6 ("not SAUCE/Revert but has no upstream reference trailer"). Add an is_ubuntu_local() helper that matches the 'UBUNTU: ' prefix; exempt those commits from R6 and R9, label them [UBUNTU] in the digest table, and verify only the Signed-off-by trailer is present. Signed-off-by: Nirmoy Das <nirmoyd@nvidia.com>
nirmoy
force-pushed
the
patchscan-buglink-existence-only
branch
from
2e132c2 to
18e4dc4
Compare
nirmoy
changed the title
Collaborator
Author
|
Closing as superseded by merged PR #410. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes PR Validation false failures reported from #407 and confirmed against #409.
Referenced report from PR #407:
validate-prreported6b97c1b33bef ("vfio/hisi: Convert to the get_region_info op")as missing upstream provenance even though the commit has(backported from commit e238f147d517...).get_region_info.Changes:
gh apiand extracting fields withjq, instead of embedding${{ github.event.pull_request.body }}directly into the shell script.validate-prto recognize(backported from commit <sha>)andUpstream commit <sha>as upstream SHA provenance.UBUNTU: [Config] ...commits do not require upstream provenance.Validation: