Skip to content

Conditional JIT warmup - #6677

Closed
maanug-nv wants to merge 6 commits into
NVIDIA:mainfrom
maanug-nv:conditional-jit-warmup
Closed

Conditional JIT warmup#6677
maanug-nv wants to merge 6 commits into
NVIDIA:mainfrom
maanug-nv:conditional-jit-warmup

Conversation

@maanug-nv

@maanug-nv maanug-nv commented Aug 19, 2026

Copy link
Copy Markdown
Contributor
  • I, the PR author, have personally reviewed every line of this PR.

What does this PR do?

Fork of changes in #2827.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact @NVIDIA/mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

@copy-pr-bot

copy-pr-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@maanug-nv
maanug-nv marked this pull request as ready for review August 19, 2026 20:05
@maanug-nv
maanug-nv requested review from a team as code owners August 19, 2026 20:05
@maanug-nv
maanug-nv force-pushed the conditional-jit-warmup branch 2 times, most recently from e48e746 to f99d7bd Compare August 19, 2026 21:20
yanliang and others added 6 commits August 19, 2026 14:22
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Cover skip paths when bias_* fusion flags are off, quick_geglu, and use_te_activation_func, using mocks so tests run without CUDA.

Signed-off-by: Maanu Grover <maanug@nvidia.com>
Repo black config uses --skip-magic-trailing-comma with line_length=100,
which collapses argument lists that fit on one line. Fixes CI linting.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
@maanug-nv
maanug-nv force-pushed the conditional-jit-warmup branch from f99d7bd to c38f6cb Compare August 19, 2026 21:25
@maanug-nv

Copy link
Copy Markdown
Contributor Author

/ok to test c38f6cb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants