Skip to content

Multimodal: add tokenizer path - #3466

Open
faradawn wants to merge 3 commits into
NVIDIA:mainfrom
IanBoyanZhang:multimodal-fix-tokenizer-path
Open

Multimodal: add tokenizer path#3466
faradawn wants to merge 3 commits into
NVIDIA:mainfrom
IanBoyanZhang:multimodal-fix-tokenizer-path

Conversation

@faradawn

Copy link
Copy Markdown
Contributor

What does this PR do ?

Fix: #3465

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@faradawn
faradawn requested review from a team as code owners February 18, 2026 00:17
@copy-pr-bot

copy-pr-bot Bot commented Feb 18, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team February 18, 2026 00:18
@janEbert janEbert added complexity: low Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. labels Feb 19, 2026
@janEbert
janEbert enabled auto-merge February 19, 2026 14:22
Signed-off-by: Faradawn Yang <73060648+faradawn@users.noreply.github.com>
@janEbert
janEbert force-pushed the multimodal-fix-tokenizer-path branch from 634f8a5 to f91cfa8 Compare February 19, 2026 14:24
@faradawn

Copy link
Copy Markdown
Contributor Author

/ok to test 20f7599

@faradawn

Copy link
Copy Markdown
Contributor Author

/ok to test f91cfa8

@faradawn

faradawn commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test f91cfa8

@dimapihtar

Copy link
Copy Markdown
Contributor

/ok to test 9b1c113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multimodal:Tokenizer path must be specified.

6 participants