Skip to content

fix: allow None dynamic_axes in OnnxLLMExporter.export #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewwhitecdw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: allow None dynamic_axes in OnnxLLMExporter.export #723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nemo_export/onnx_llm_exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ def _export_to_onnx(
f=self.onnx_model_path,
input_names=input_names,
output_names=output_names,
dynamic_axes={**dynamic_axes_input, **dynamic_axes_output},
dynamic_axes={**(dynamic_axes_input or {}), **(dynamic_axes_output or {})},
verbose=verbose,
opset_version=opset,
dynamo=False,
Expand Down
20 changes: 20 additions & 0 deletions tests/unit_tests/export/test_onnx_llm_exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,3 +106,23 @@ def test_quantize_without_modelopt(self):
pytest.raises(UnavailableError),
):
OnnxLLMExporter().quantize(quant_cfg="", forward_loop="")

def test_export_allows_none_dynamic_axes(self, temp_dir, dummy_model, dummy_tokenizer):
exporter = OnnxLLMExporter(
onnx_model_dir=temp_dir,
model=dummy_model,
tokenizer=dummy_tokenizer,
load_runtime=False,
)
example_inputs = {"input_ids": torch.randint(0, 10, (2, 4), device=exporter.device)}
with mock.patch("nemo_export.onnx_llm_exporter.torch.onnx.export") as mock_export:
exporter.export(
input_names=["input_ids"],
output_names=["output"],
example_inputs=example_inputs,
dynamic_axes_input=None,
dynamic_axes_output=None,
)

_, kwargs = mock_export.call_args
assert kwargs["dynamic_axes"] == {}
Loading