Introduce new shampoo and soap - #281
Merged
Merged
Conversation
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
skyw
force-pushed
the
skyw/introduce_new_shampoo_and_soap
branch
from
August 7, 2026 23:25
f050252 to
a9b2fcf
Compare
Contributor
Author
|
@greptileai review the draft |
Contributor
Author
|
/ok to test a9b2fcf |
Contributor
Greptile SummaryThe PR promotes the experimental SOAP redesign into a dedicated Shampoo package and expands its preconditioner abstraction.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (8): Last reviewed commit: "relax threshold for rekls" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Author
|
/ok to test a9b2fcf |
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
skyw
marked this pull request as ready for review
August 8, 2026 03:23
Signed-off-by: Hao Wu <skyw@nvidia.com>
Contributor
Author
|
/ok to test 715ce11 |
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Contributor
Author
|
/ok to test 4f516ff |
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Contributor
Author
|
/ok to test 74ac1aa |
Contributor
Author
|
/ok to test f3fe539 |
Signed-off-by: Hao Wu <skyw@nvidia.com>
Contributor
Author
|
/ok to test be08912 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve abstraction. clear path for more variant of Shampoo and Soap.