fix(playback): serve streams via WEB_REMIX only#42
Open
mihaimetal wants to merge 2 commits into
Open
Conversation
Avoid the managed PyInstaller yt-dlp (~12s process start) on the hot path by resolving ANDROID_VR player URLs in-process and streaming progressively; fall back to PATH-preferred yt-dlp when needed. Drop next-track prefetch so only the current track is buffered.
Resolve progressive WebM with cookies + SAPISIDHASH (raw Music /player and youtubei.js decipher), probe before register, and drop ANDROID_VR / yt-dlp from the hot path (left re-enableable). Cap stream.log at 2 MiB with rotation, and remove the resolver status line under the artist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/playerplusyoutubei.jsdecipher.logs/stream.logat 2 MiB with rotation tostream.log.1.resolving…/WEB_REMIX/ timing).Why
Cold start with managed PyInstaller yt-dlp was very slow (~12s process spawn). WEB_REMIX with a proper cookie/SAPISIDHASH path gives reliable progressive playback without the multi-client fallback noise (ANDROID_VR
LOGIN_REQUIRED, MWEB 403s, etc.).Design notes for review
'unsafe-eval'so nsig decipher can run in the webview.stream.log/ console for debugging; just not shown under the artist.Commits
Test plan
stream.logshowsweb_remix/ probe / music+cookie path (no yt-dlp / android_vr spam)YTubic.appruns successfullyRelated
Independent of the macOS packaging and auth PRs; can merge in any order, though packaging helps reviewers who build on Mac.