fix(auth): harden macOS Google sign-in and sign-out#41
Open
mihaimetal wants to merge 1 commit into
Open
Conversation
WKWebView does not honor data_directory for cookie isolation, so Google sessions survived sign-out in the shared HTTPStorages store and Music web showed GET CHROME after SSO. Use per-account data store identifiers, wipe residual WebKit auth data on sign-out, hand off via www.youtube.com on macOS, avoid interrupting 2FA challenges, and make last-account sign-out a full wipe from the UI.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data_directoryfor cookie isolation).www.youtube.comon macOS; avoid interrupting 2FA challenges.Context
On macOS, signed-out accounts could still appear authenticated to Google / YouTube Music web (e.g. GET CHROME after SSO) because sessions survived in the shared HTTP cookie store. This is a WebKit-specific isolation problem and should not change Windows DPAPI cookie behavior.
Test plan