build: enable macOS app/dmg bundle targets#40
Open
mihaimetal wants to merge 1 commit into
Open
Conversation
Allow packaging on macOS alongside the existing Windows NSIS target, and gate the Windows-only Manager import so the media module compiles cleanly on non-Windows hosts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.app/.dmgbundle targets alongside the existing Windows NSIS target.Managerimport so the media module compiles cleanly on non-Windows hosts.Context
Needed to produce macOS release builds of YTubic during local development. Small, low-risk packaging change with no runtime behavior impact on Windows.
Test plan
pnpm tauri buildon macOS producesYTubic.appand DMG