fix: 協賛ページ権限の調整と請求書編集の手入力対応#1101
Open
TkymHrt wants to merge 9 commits into
Open
Conversation
Deploying finansu with
|
| Latest commit: |
4b99ba3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a3c5cb2c.finansu.pages.dev |
| Branch Preview URL: | https://feat-codex-sponsor-invoice-e.finansu.pages.dev |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables editing of sponsor, manager, and staff names within the progress report invoice modal and updates state management to use functional updates for better reliability. It also expands access permissions to include role ID 4. Review feedback suggests improving the PDF layout by conditionally hiding labels when names are empty and recommends using Array.includes for more maintainable role-based access checks.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
対応Issue
概要
本ブランチでの変更内容は以下の通りです。
/sponsor-activities）および協賛活動ページ（/sponsors）における権限設定の調整画面スクリーンショット等
テスト項目
備考