Skip to content

[DIRECT] Add stale domain origins, tool-registry drift, and claim-readiness tests (#684, #685, #682) - #736

Open
elevasyncsolutions-jpg wants to merge 2 commits into
NSPG13:mainfrom
elevasyncsolutions-jpg:add-more-direct-tests
Open

[DIRECT] Add stale domain origins, tool-registry drift, and claim-readiness tests (#684, #685, #682)#736
elevasyncsolutions-jpg wants to merge 2 commits into
NSPG13:mainfrom
elevasyncsolutions-jpg:add-more-direct-tests

Conversation

@elevasyncsolutions-jpg

Copy link
Copy Markdown

Summary

Three deterministic offline test suites for DIRECT bounties #684, #685, and #682.


#684 — Stale domain origins test

  • Verifies canonical origins (agentbounties.app, api.agentbounties.app, mcp.agentbounties.app) are accepted
  • Verifies stale legacy origins are rejected/absent from generated output
  • Covers origin validation and generated links/redirects
  • File: scripts/test_stale_domain_origins.py + scripts/fixtures/rte_stale_domain_origins.json

#685 — MCP/API tool-registry drift test

  • Compares MCP tool registry with API discovery manifest
  • Checks required tools exist in both: list_autonomous_bounties, list_opportunities, prepare_agent_to_earn, prepare_bounty_post
  • Detects duplicates, missing, or renamed tools
  • Distinguishes MCP transport endpoint from JSON tool inventory endpoint
  • File: scripts/test_mcp_api_tool_drift.py

#682 — Claim-readiness diagnostics fixture

  • Covers healthy direct bounty, recovery-reserved bounty, unprofitable bounty, non-creator failure
  • Each exposes reward, bond, external spend, gross cash margin, actionable blocker
  • Never requests private key or seed phrase
  • Gross cash margin clearly distinguished from guaranteed net profit
  • No result describes a plan/tx/hash/row as payment
  • File: scripts/test_claim_readiness.py + scripts/fixtures/rte_claim_readiness.json

Acceptance

All 48 tests pass, offline, replayable, exit 0. No secrets, no wallet, no live write.

Closes #684
Closes #685
Closes #682

smslc added 2 commits July 31, 2026 03:14
Add deterministic Python test verifying the ready-to-earn inventory
projection excludes canonical bounties with:
- verification_ready=false
- recovery-reserved state
- invalid terms
- terminal status (settled, paid, expired, cancelled)

Uses committed fixture only — no network, no secrets, no wallet.
@NSPG13

NSPG13 commented Aug 4, 2026

Copy link
Copy Markdown
Owner

The PR is in the manual-security-review lane because it combines API, MCP, and claim-readiness changes. What passed: it covers several useful failure modes. What blocks main: the combined scope creates contract and rollback risk and overlaps focused PRs. Action: split the three concerns, run cargo run -p cli -- docs-contract-check and the relevant focused tests per PR, and document one canonical source of truth per check. Done when each smaller PR can be reviewed and reverted independently. Thanks for helping the community grow, and sorry for the review friction. This is not merge, bounty, or payment approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants