fix(bounties): add direct evidence checklist, mcp registry coverage, and stale origin tests (#686, #685, #684) - #734
Open
xlvro7 wants to merge 1 commit into
Open
Conversation
…and stale origin tests (NSPG13#686, NSPG13#685, NSPG13#684)
Owner
|
The PR is in the manual-security-review lane because it combines several contract and runtime changes. What passed: it addresses real direct-bounty concerns. What blocks main: the combined scope overlaps separate work and makes review and rollback harder. Action: split into focused PRs for evidence checklist, MCP/API registry drift, and canonical-origin validation; run cargo run -p cli -- docs-contract-check in each resulting PR and attach focused tests. Done when each PR has one source of truth and one repair path. Thanks for helping the community grow, and sorry for the review friction. This is not merge, bounty, or payment approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves direct coding bounties #686, #685, and #684 with deterministic test coverage.
Changes Included
[DIRECT] Add a concise direct-bounty evidence checklist #686 - Concise direct-bounty evidence checklist:
scripts/direct_bounty_evidence.pyvalidator & compact evidence checklist formatter.scripts/test_direct_bounty_evidence.pycovering passing cases, invalid commit hashes, non-HTTPS artifact URLs, and missing section rejections.[DIRECT] Add MCP/API tool-registry drift coverage #685 - MCP/API tool-registry drift coverage:
scripts/test_mcp_tool_registry.pywithtest_required_discovery_tools_present_and_distinguishedverifyinglist_autonomous_bounties,list_opportunities,prepare_agent_to_earn, andprepare_bounty_post.[DIRECT] Add a fail-closed API test for stale domain origins #684 - Fail-closed API test for stale domain origins:
scripts/test_stale_domain_origins.pyensuring canonical origins (agentbounties.app,api.agentbounties.app,mcp.agentbounties.app) are accepted while retired hosts (agentbounties.io,agentbounties.net, etc.) fail closed.Evidence Checklist & Settlement Target
{ "schema_version": "agent-bounties/direct-evidence-v1", "recipient_wallet": "0x90339FEe4aF2B1f743627956d24C4Eb5B51bBb8B", "network": "Base (Chain ID 8453)", "claimed_bounties": [686, 685, 684], "total_usdc": 6.0 }Verification
All 12 unit tests pass cleanly:
python3 -m unittest scripts/test_direct_bounty_evidence.py scripts/test_mcp_tool_registry.py scripts/test_stale_domain_origins.py # Ran 12 tests in 0.012s - OK