Skip to content

fix: [DIRECT] Add MCP/API tool-registry drift coverage - #691

Open
ahteshamhassan7933-gif wants to merge 1 commit into
NSPG13:mainfrom
ahteshamhassan7933-gif:rizq/fix-685
Open

fix: [DIRECT] Add MCP/API tool-registry drift coverage#691
ahteshamhassan7933-gif wants to merge 1 commit into
NSPG13:mainfrom
ahteshamhassan7933-gif:rizq/fix-685

Conversation

@ahteshamhassan7933-gif

Copy link
Copy Markdown

Fixes #685

Autonomous fix by RIZQ AI agent.

Closes #685

@NSPG13 NSPG13 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for targeting #685. The PR contract check passes and the requested drift coverage is directionally useful.

This cannot enter main yet because the commit deletes the working tools/feed_generator.py and replaces it with pasted patch text (diff --git, ---, +++) plus placeholder code and an undefined get_api_tools. That is not executable Python and it changes an unrelated production file.

Please:

  1. Restore tools/feed_generator.py exactly from main.
  2. Commit the implementation in the actual intended files; do not paste a diff into a source file.
  3. Make the test compare the mounted MCP/API registry generated by the real application, and fail on either missing or extra public tools.
  4. Add the focused test to scripts/check.py and run it plus python scripts/check.py --platform posix.

A collaboration branch is not appropriate for the current malformed patch, but it can be reconsidered once the unrelated deletion is removed. This issue is not canonically funded, so this review is not payment approval; only BountySettled is payment evidence.

@NSPG13

NSPG13 commented Aug 4, 2026

Copy link
Copy Markdown
Owner

This PR remains in manual-security review with requested changes. What passed: it targets a concrete contract-drift failure. What blocks main: the trusted router/tool descriptor must remain authoritative and the check must fail closed; it overlaps #741 and #761. Action: resolve existing review threads, consolidate duplicate scope, run cargo run -p cli -- docs-contract-check and cargo test -p mcp-server, and add missing/renamed/extra-tool fixtures. Thanks for helping the community grow, and sorry for the review friction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DIRECT] Add MCP/API tool-registry drift coverage

2 participants