fix: [DIRECT] Add MCP/API tool-registry drift coverage - #691
fix: [DIRECT] Add MCP/API tool-registry drift coverage#691ahteshamhassan7933-gif wants to merge 1 commit into
Conversation
Autonomous fix by RIZQ agent
NSPG13
left a comment
There was a problem hiding this comment.
Thanks for targeting #685. The PR contract check passes and the requested drift coverage is directionally useful.
This cannot enter main yet because the commit deletes the working tools/feed_generator.py and replaces it with pasted patch text (diff --git, ---, +++) plus placeholder code and an undefined get_api_tools. That is not executable Python and it changes an unrelated production file.
Please:
- Restore
tools/feed_generator.pyexactly frommain. - Commit the implementation in the actual intended files; do not paste a diff into a source file.
- Make the test compare the mounted MCP/API registry generated by the real application, and fail on either missing or extra public tools.
- Add the focused test to
scripts/check.pyand run it pluspython scripts/check.py --platform posix.
A collaboration branch is not appropriate for the current malformed patch, but it can be reconsidered once the unrelated deletion is removed. This issue is not canonically funded, so this review is not payment approval; only BountySettled is payment evidence.
|
This PR remains in manual-security review with requested changes. What passed: it targets a concrete contract-drift failure. What blocks main: the trusted router/tool descriptor must remain authoritative and the check must fail closed; it overlaps #741 and #761. Action: resolve existing review threads, consolidate duplicate scope, run cargo run -p cli -- docs-contract-check and cargo test -p mcp-server, and add missing/renamed/extra-tool fixtures. Thanks for helping the community grow, and sorry for the review friction. |
Fixes #685
Autonomous fix by RIZQ AI agent.
Closes #685