Skip to content

Update the W3 interface in qctropcy and bring in a v16 fix for getjtbul#176

Merged
DavidHuber-NOAA merged 3 commits into
NOAA-EMC:developfrom
DavidHuber-NOAA:fix/syndat
Mar 17, 2026
Merged

Update the W3 interface in qctropcy and bring in a v16 fix for getjtbul#176
DavidHuber-NOAA merged 3 commits into
NOAA-EMC:developfrom
DavidHuber-NOAA:fix/syndat

Conversation

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

Description

This adds updated support for W3EMC v3.10+ in the qctropcy program. As of v2.10, only single-precision real values are accepted.

This also brings in a version 16 fix to getjtbul that correctly handles tabs.

Type of change

  • Bug fix (fixes something broken)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

Ran the executables in near-realtime on WCOSS2 and verified reproducibility against v16.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes

Comment thread src/syndat_qctropcy.fd/qctropcy.f Outdated
@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor Author

@Qingfu-Liu would you mind reviewing this PR? Part of this PR brings in the fix you made for GFS v16.3.21 to getjtbul.

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor Author

This was tested on WCOSS2-Cactus and returned identical results to v16.

Copy link
Copy Markdown

@TravisElless-NOAA TravisElless-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getjbul.f file correctly matches the file in operations. Since tests pass and are able to reproduce v16 results, I approve of these changes

@DavidHuber-NOAA DavidHuber-NOAA merged commit 164fd01 into NOAA-EMC:develop Mar 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants