Update the W3 interface in qctropcy and bring in a v16 fix for getjtbul#176
Merged
Merged
Conversation
11 tasks
DavidHuber-NOAA
commented
Mar 16, 2026
Contributor
Author
|
@Qingfu-Liu would you mind reviewing this PR? Part of this PR brings in the fix you made for GFS v16.3.21 to |
Contributor
Author
|
This was tested on WCOSS2-Cactus and returned identical results to v16. |
TravisElless-NOAA
approved these changes
Mar 17, 2026
TravisElless-NOAA
left a comment
There was a problem hiding this comment.
The getjbul.f file correctly matches the file in operations. Since tests pass and are able to reproduce v16 results, I approve of these changes
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds updated support for W3EMC v3.10+ in the
qctropcyprogram. As of v2.10, only single-precision real values are accepted.This also brings in a version 16 fix to
getjtbulthat correctly handles tabs.Type of change
Change characteristics
How has this been tested?
Ran the executables in near-realtime on WCOSS2 and verified reproducibility against v16.
Checklist