Skip to content

update main - #163

Merged
kaydin merged 38 commits into
mainfrom
dev
Sep 5, 2025
Merged

update main#163
kaydin merged 38 commits into
mainfrom
dev

Conversation

@andybeet

@andybeet andybeet commented Aug 23, 2025

Copy link
Copy Markdown
Member

Bug fixes

  • Correct accounting of interdetrital flows.
  • Ability to run models without any stanzas. PR Pb fixes #162
  • Fix missing/infinte X (CAN WE EXPLAIN WHY THIS HAPPENED?) Yes (KA note). This is warned about in check.rpath.params() and happens when certain parameters are missing certain required inputs. It isn't "fixed" in that models with these problems are underspecified and won't work. The "fix" is to trap the error with a slightly more intelligent error message directing the user towards which parameters may be missing. Also, there are many fewer of these errors now that the "estimate unknown PB" feature was added (previously the most common missing parameter error trigger in our test set).
  • Fix of ordering assumption in create.rpath.params. Previous code assumed that all stanzas of a particular species were grouped together in the main model, not interspersed in the main table with other stanza species. PR Stanza order fix #164
  • Better warning messages

Minor Changes

New Features

andybeet and others added 30 commits August 6, 2025 15:42
Bringing minor recent patches to main back into dev
fixed interdetrital flows (EEs and ecosim equilibrium), removed a det…
…, instead of returning wrong values (CHANGE OF OUTPUT BEHAVIOR)
@andybeet
andybeet requested a review from kaydin September 5, 2025 17:52
@kaydin
kaydin merged commit 55fe84d into main Sep 5, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants