Feature/GPCAPIM 351 tests for GPProvider stub#171
Draft
Conversation
- Add assertions to validate response headers and body structure - Verify that the response contains the expected resource type and entry details
- Implement tests for missing headers in the POST request - Validate JWT format in the Authorization header - Ensure correct error responses for invalid requests
…d endpoint - Implement tests for invalid Content-Type header - Add tests for invalid Interaction ID header - Include tests for JWT decoding and validation errors
- Add type check for diagnostics to ensure it is a string - Confirm error message for authorization header format in validation tests
- Add formatting rules for Python files and Markdown content - Include guidelines for Terraform file compatibility - Expand vocabulary list for Vale checks
…acts - Add exclusions for generated artefacts, lock files, and data fixtures - Include paths for NHS codes and FHIR field names in cSpell ignore list
- Expand cSpell dictionary with additional terms - Correct minor spelling errors in comments and documentation
- Rename parameter for clarity from 'pract' to 'practitioner' - Update error handling to use 'practitioner_errors' for consistency - Ensure validation checks for resourceType and identifiers are clear and concise
- Add entry for local contract test pact output
- Excluded the pact output file for local contract tests
- Eliminate unnecessary check for trace_id being None as the `get` method provides a fallback
- Remove trace_id from request to provider_stub - Rename test class for header validation errors - Add test for missing body in structured record request - Ensure proper error handling and response for missing body
|
|
Deployment Complete
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add contract testing for ProviderStub
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.