Various Refactors (suppPrecipMod.py, parallel.py, bmi_model.py, config.py, model.py, layeringMod.py, timeInterpMod.py) - #238
Merged
Conversation
…sts.py, symbol misspelling, and stale ewts reference.
…t_bounds", and "lon_bounds" (ignore hashes).
…y, travel recursively instead of falling back to pure equality tests after initial shallow inspection. This allows nested objects to have the numerical tolerances applied as intended.
…aii. Increase AORC buffer to 6km. Assert that the projection is meters
…one directly instead of implicitly.
… positive, not just non-negative. i.e. disallow value 0.
… certain config combinations.
…d, with error message and docstrings pointing to pending code where pending attempts are made to support these alternate discretization types.
…scretization type
… by discretization type
mxkpp
changed the title
suppPrecipMod.py, parallel.py, bmi_model.py, config.py, model.py, layeringMod.py, timeInterpMod.py)suppPrecipMod.py, parallel.py, bmi_model.py, config.py, model.py, layeringMod.py, timeInterpMod.py)
mxkpp
force-pushed
the
NGWPC-7625_PI_10_ngen_forcing_refactor
branch
from
August 27, 2026 22:09
333ff5e to
66004b6
Compare
Author
|
After rebasing, the ngen-forcing pytests passed and the nwm-rte run_suite.sh workflows ran successfully again. Merging. |
Author
|
Note: the activity above indicates that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes file refactors from the summer of 2026 and adds
README_refactor_2026.mdFiles refactored
suppPrecipMod.py#134parallel.py#201bmi_model.py,config.py,model.py: #191layeringMod.py: #224timeInterpMod.py: #226The
ngen-forcingpytests passed and thenwm-rterun_suite.shworkflows ran successfully.