Optimize 1D direct NFFT by carrying the phase by recurrence.#212
Draft
jenskeiner wants to merge 2 commits into
Draft
Optimize 1D direct NFFT by carrying the phase by recurrence.#212jenskeiner wants to merge 2 commits into
jenskeiner wants to merge 2 commits into
Conversation
82ce491 to
93b2bd3
Compare
f54814b to
56f7684
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an optimization to the 1D direct NFFT algorithm that should result in performance improvements.
It's an example of a result obtained by using a coding agent with a harness to guide the code optimization process and ensure correctness. I'll leave it here for a bit before merging.
Unfortunately, the benchmarks suffer from noise from different GitHub runners and thus are not really comparable with
develop; see https://codspeed.io/blog/why-glibc-faster-github-actions.To fix this, we should switch to CodSpeeds Macro Runners. The drawback may be that we can easily hit the 500 minutes per month quota on the free tier. However, for open-source projects, they may be willing to increase the quota as per their website.
It would be best to merge this PR only when we have removed the noise from our CI.