Enabling clang tidy CI failures

[K20shores]

Closes #988

• enables clang tidy to cause failures
• places all checks in the dockerfile so they can easily be run on local computers
• nothing is addressed yet because there's too many to comfortably do in one PR
  • Address clang-tidy failures #997 lists all known failures that will be fixed in future PRs

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.95%. Comparing base (302a3ef) to head (da2be68).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #998   +/-   ##
=======================================
  Coverage   94.95%   94.95%           
=======================================
  Files          53       53           
  Lines        4397     4399    +2     
=======================================
+ Hits         4175     4177    +2     
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[boulderdaze]

I know at least one constant GAS_CONSTANT is not lower case.

[K20shores]

true, do you have a preference for how we should name these? We have said in the past that we adhere to the google style guide, but they have a different naming convention for constants. I don't actually care what pattern we you, so happy to make clang tidy do whatever you like most

[boulderdaze]

I think we can just use uppercase since the constants defined in util/constants.hpp use uppercase, though I could be wrong in other part of the code. In that case, we might want to disable this check. I also don’t have a preference about code style.

[boulderdaze]

Not a big deal, but since the PR title becomes the content of the release, it might be nice to make the issue name a bit more formal.

[K20shores]

Not a big deal, but since the PR title becomes the content of the release, it might be nice to make the issue name a bit more formal.

updated. Feel free to change it if you have a better idea