Remove Python testing framework for capgen tests#742
Closed
climbfuji wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Deferring this issue to after the capgen unification |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Python testing framework for capgen tests.
Welcoming feedback on whether this is a good idea or not. Does the Python framework test aspects of the API that the CMake tests don't test? Should we rather remove the CMake-Fortran tests? Or can we update them? What I don't want is testing frameworks that are redundant. For example, every time a variable changes in the output list, one has to fix the Fortran test code and the Python test code.
I noticed that the most recently added test (
nested_suite) doesn't even have the Python-based tests.User interface changes? No
Closes #741
Testing:
test removed: redundant Python-based tests that run on top of the CMake
ctestcapgen tests