Update Codee formatter to require a space after .not. and format all files that should be formatted#733
Conversation
… feature/codee_logical_not_spaces
climbfuji
changed the title
peverwhee
left a comment
peverwhee
left a comment
There was a problem hiding this comment.
truly one of my most annoying requests.
| RelationalLegacy: Both | ||
| LogicalBinary: Both | ||
| LogicalNot: NoTrailing | ||
| LogicalNot: Both |
There was a problem hiding this comment.
This is annoying of me since this was all originally my suggestion, but maybe this should actually be Trailing?
My nit-picky concern is that Both is resulting in lines like these:
if ( .not. thing) then
which has inconsistent parenthetical spacing. .not. is weird because sometimes it comes right after the parenthesis, but not always.
If Trailing is applied to the original code (rather than the modified code in this PR), I think it'd get at what I was looking for.
It's not really a hill I want to die on, but I imagine it'd be annoying if someone committed code like:
if (.not. thing) then
and got codee failures.
There was a problem hiding this comment.
No problem, easy enough to revert.
… feature/codee_logical_not_spaces
…ows/fortran-formatting.yaml
| @@ -1,5 +1,8 @@ | |||
| program test | |||
| use test_prog, only: test_host, suite_info, cm, cs | |||
| use test_prog, only: test_host, & | |||
There was a problem hiding this comment.
Note, this is a fix in Codee. The rule to break use statements into one line per module was always there, but earlier versions ignored it.
| RelationalLegacy: Both | ||
| LogicalBinary: Both | ||
| LogicalNot: NoTrailing | ||
| LogicalNot: Trailing |
dustinswales
left a comment
dustinswales
left a comment
There was a problem hiding this comment.
This looks good to me.
I had a comment that you can take or leave.
|
All, I am planning to meet this by COB today. It's been out for reviews for more than two weeks, and it has approvals from NCAR and NOAA (and NAVY, obviously). |
3 participants
Update codee formatter to require a space after .not. and format all files that should be formatted
.codee-format:LogicalNot: NoTrailing-->Both*.F90that should be formatted files with Codee (this excludes code to be removed in Cleanup: remove unused directories logging/* and stub/* #738 and all files undertest/unit_testsas discussed below)2026.1.2from April 21, 2026User interface changes?: No
Fixes #728
Testing: no changes, all pass
test removed:
unit tests:
system tests:
manual testing: