Colocate node icons per node and copy them during build#16
Merged
Conversation
Align build.js with the node-red-example template: add copyIcons() to transfer each node's src/nodes/<node>/icons into dist/nodes/<node>/icons, drop the unused plugin/theme stubs. Move the icons out of the central icons/ directory into their nodes, ship src/resources instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was & Warum
Richtet Build-Script und -Routine am Template node-red-example aus und korrigiert die Icon-Platzierung.
Änderungen
build.js: neuecopyIcons()-Funktion kopiert Icons pro Node vonsrc/nodes/<node>/icons/→dist/nodes/<node>/icons/. TotebuildPlugins()/buildThemes()-Stubs entfernt, Funktionen umbenannt (buildForm/copyLocales), durchgehendnode:-Imports.icons/<node>.svg→src/nodes/<node>/icons/<node>.svg; Top-Levelicons/entfernt. Dieicon: "….svg"-Referenzen bleiben gültig (Node-RED registrierticons/-Ordner neben den Node-Dateien automatisch).package.jsonfiles:iconsraus,src+resourcesrein (analog Template);resources/.gitkeepals Platzhalter.Verifiziert
npm run buildläuft sauber,dist/nodes/*/icons/*.svgwerden erzeugt.