Fix missing nodes in the palette (isolate editor scripts)#15
Merged
Conversation
The generated editor scripts declared their definition object and helper functions at the top level. Since Node-RED evaluates every node's editor script in the same global scope, the second node's `const def` threw "Identifier 'def' has already been declared", which aborted that script and left the node missing from the palette — only the first node registered. Wrap each init script in an IIFE so its declarations stay local.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the review fixes.
Every node's editor script declared its definition object (
const def) andhelper functions at the top level. Node-RED evaluates all node editor
scripts in the same global scope, so the second node's
const defthrew"Identifier 'def' has already been declared", aborting that script — only
the first node (sACN in) appeared in the palette.
Wrapping each generated init script in an IIFE keeps those declarations
local. The scripts still access the globals they need (
RED,$,document) via closure, andregisterTyperuns inside the IIFE.