Add gRPC proto JSON transaction results#1145
Merged
Merged
Conversation
hayes-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
July 16, 2026 17:46 — with
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
hayes-mysten
force-pushed
the
mh/grpc-client-proto-json
branch
from
July 16, 2026 18:03
c014e5f to
ee1bc16
Compare
hayes-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
July 16, 2026 18:03 — with
GitHub Actions
Inactive
hayes-mysten
force-pushed
the
mh/grpc-client-proto-json
branch
from
July 16, 2026 19:02
ee1bc16 to
917a1cc
Compare
hayes-mysten
had a problem deploying
to
sui-typescript-aws-kms-test-env
July 16, 2026 19:02 — with
GitHub Actions
Failure
hayes-mysten
force-pushed
the
mh/grpc-client-proto-json
branch
from
July 16, 2026 19:07
917a1cc to
0a28693
Compare
hayes-mysten
had a problem deploying
to
sui-typescript-aws-kms-test-env
July 16, 2026 19:07 — with
GitHub Actions
Failure
hayes-mysten
force-pushed
the
mh/grpc-client-proto-json
branch
from
July 16, 2026 19:09
0a28693 to
25e987e
Compare
hayes-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
July 16, 2026 19:09 — with
GitHub Actions
Inactive
hayes-mysten
force-pushed
the
mh/grpc-client-proto-json
branch
from
July 16, 2026 21:08
25e987e to
9805cb7
Compare
hayes-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
July 16, 2026 21:08 — with
GitHub Actions
Inactive
Contributor
Author
|
@clud-bot review |
Contributor
|
Review sub-agent spawned. I'll wait for its verdict and then post to GitHub. |
Contributor
There was a problem hiding this comment.
Review: Approve ✅
Clean, low-risk refactor plus an additive feature. The read-mask helper extraction is byte-for-byte equivalent to the three inline blocks it replaces, withProtoJson correctly adds the opt-in protoJson field only when requested, the conditional ProtoJson typing and as Promise<...> casts hold, and cross-client consistency is preserved (protoJson is a gRPC-only additive include, defaults off).
Verified locally:
vitest run test/unit/grpc/parse-transaction-response.test.ts— ✅ 3/3pnpm --filter @mysten/sui build— ✅pnpm --filter @mysten/sui test:typecheck— ✅
One minor note inline: the changeset bump level looks like it should be minor rather than patch since new public API is exported.
Co-authored-by: clud-bot[bot] <258312010+clud-bot[bot]@users.noreply.github.com>
hayes-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
July 16, 2026 21:25 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SuiGrpcClienttransaction include/result types forinclude: { protoJson: true }.GrpcCoreClient's public type surface on the shared core transaction result types while supporting the extra include at runtime.transactionReadMaskPaths(include, prefix?).Test plan
pnpm --filter @mysten/sui vitest run test/unit/grpc/parse-transaction-response.test.tspnpm --filter @mysten/sui test:typecheckpnpm --filter @mysten/sui buildAI Assistance Notice