fix(voice): rimuovi clearChunks ridondante + aggiorna commenti obsoleti#19
fix(voice): rimuovi clearChunks ridondante + aggiorna commenti obsoleti#19
Conversation
…rupted stopPlayback() resetta già tutto lo stato interno dell'AudioPlayer (chunkCounter, pendingChunks, allChunksReceived, sessionId++). Chiamare clearChunks() subito dopo causava un doppio incremento di sessionId senza alcun beneficio. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Rimossi riferimenti al 'server gate in voice_bridge.py' che non esiste più dopo la refactor lato server. Il VAD è ora gestito interamente dal server-side VAD di OpenAI Realtime API. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Code Review - overall a clean and focused PR. |
|
Code Review Overall this is a clean, focused PR with a small diff and a clear rationale. Here is my analysis. Main fix — removal of redundant clearChunks() Correct. In src/utils/audioUtils.ts, stopPlayback() (~line 690) already does this.sessionId++ and resets chunkCounter, pendingChunks, and allChunksReceived to their initial values. clearChunks() (~line 683) does exactly the same thing. Calling clearChunks() right after stopPlayback() caused a double sessionId++. While this did not produce visible bugs (in-flight addChunk calls capture mySession synchronously before either increment, so they are already invalidated by the first stopPlayback() increment), it was semantically wrong and redundant. Removing it is the right call. Comment updates Both changes are accurate:
Minor suggestions (non-blocking)
Summary: bug fix is correct, comment updates are accurate, scope is focused with no unrelated changes, no security concerns. Approved. |
Sommario
Pulizia codice in
useVoiceChat.tsa seguito della refactor server-side (rimozioneVoiceAudioGate).Modifiche
Fix ridondanza — handler
interruptedinonStatus:stopPlayback()resetta già tutto lo stato dell'AudioPlayer(chunkCounter,pendingChunks,allChunksReceived,sessionId++)clearChunks()subito dopo causava un doppiosessionId++inutileCommenti aggiornati — rimossi riferimenti a "server gate in voice_bridge.py" che non esiste più dopo la refactor lato server (PR #81 su MyTaskly-server)
Commit
fix(voice): rimozioneclearChunksridondante dopostopPlaybackrefactor(voice): aggiornamento commenti obsoleti su server gate