add chat history session

[Gabry848]

This pull request introduces a comprehensive chat history feature to the application, including both backend documentation and a new frontend UI for managing chat sessions. The changes implement a server-managed chat history system, update the documentation to reflect the new SSE streaming protocol, and add React Native components for browsing, pinning, and deleting chat histories. Additionally, demo data is provided for development and testing.

Key changes include:

Chat History UI Components

• Added a new ChatHistory React Native component that displays a list of chat sessions, supports infinite scroll, pull-to-refresh, pinning/unpinning, and deletion of chats. The component handles loading states, error handling, and empty state UI. (src/components/BotChat/ChatHistory.tsx)
• Introduced a ChatHistoryItem component to render individual chat session entries, showing title, preview, timestamp, message count, and action buttons for pinning and deleting. (src/components/BotChat/ChatHistoryItem.tsx)

Demo Data

• Provided a demo chat history dataset for development and UI testing, following the ChatHistoryItemData structure. (src/data/demoChatHistory.ts)

Backend Protocol and Documentation

• Added detailed documentation for the new chat SSE streaming protocol, describing request/response formats, event types, client integration, best practices, and troubleshooting. This clarifies how the server now manages chat history via chat_id, removing the need for the client to send the entire message history with each request. (IA_docs/CHAT_SSE_STREAMING.md)

Integration Points

• Updated the main chat screen to import chat history service functions and manage the currentChatId state, preparing for integration with the new chat history features. (src/navigation/screens/BotChat.tsx) [1] [2]

---

References:

• Chat History UI: [1] [2]
• Demo Data:
• SSE Streaming Documentation:
• Integration Updates: [1] [2]

[claude]

Pull Request Review: Chat History Session Feature

This PR introduces a comprehensive chat history management system. Overall, this is a well-structured implementation with good separation of concerns.

Strengths

• Clean separation between UI components and service layer
• Proper TypeScript interfaces and React patterns
• Comprehensive API documentation
• Infinite scroll, pull-to-refresh, pin/unpin functionality
• Good error handling with try-catch blocks

Critical Issues (Must Fix Before Merge)

1. Hardcoded Timezone Offset (ChatHistoryItem.tsx:35)

   • Line: const diffInMs = now.getTime() - date.getTime() + (240 * 60 * 1000);
   • Issue: 240 minutes hardcoded offset breaks for other timezones
   • Fix: Use proper timezone handling or remove offset

2. Race Condition (ChatHistory.tsx:54-58)

   • Ref check not atomic, multiple calls could pass
   • Fix: Use AbortController or debounce

3. Missing useEffect Dependencies (ChatHistory.tsx:164)

   • loadChatHistory not in dependency array
   • Could cause stale closure issues

High Priority Issues

4. Inconsistent Error Handling

   • Mix of console.error, setState, and Alerts
   • Need consistent strategy

5. No Loading State for Pin Toggle (ChatHistory.tsx:123-150)

   • Users might click multiple times
   • Add per-item loading state

6. Dynamic Import Anti-pattern (ChatHistory.tsx:125)

   • toggleChatPin already imported at top
   • Remove unnecessary dynamic import

Medium Priority

7. BotChat.tsx Complexity (403 lines)

   • Handles too many concerns
   • Extract into smaller hooks

8. Client-side Re-sorting Performance (ChatHistory.tsx:140-146)

   • Full re-sort on every pin toggle
   • Inefficient with large lists

9. Missing Tests

   • No tests for chatHistoryService
   • No component tests
   • No integration tests

Low Priority Polish

10. Hardcoded Italian Locale (ChatHistoryItem.tsx:47)

    • toLocaleDateString('it-IT')
    • Use i18n instead

11. Demo Data Unused

    • demoChatHistory.ts created but never used
    • Either use or remove

12. Magic Numbers

    • LIMIT=20, keyboardVerticalOffset=35
    • Extract to constants

Security

Good: Token management, server-side sessions
Recommendations: Validate chat_id, ensure XSS protection, add rate limiting

Performance

• Consider React.memo for ChatHistoryItem
• Add getItemLayout to FlatList
• Review onEndReachedThreshold value

Test Coverage

Missing tests for all new components and services. Aim for 70% coverage.

Verdict

Request Changes - Critical issues (especially timezone) must be fixed before merge.

Estimated effort:

• Critical: 2-3 hours
• High priority: 4-5 hours
• Medium: 6-8 hours (can be follow-up)

Great work overall! Well-designed feature with high code quality, just needs polish on the issues above.