Skip to content

Improve summary detail layout - #29

Merged
MyButtermilk merged 3 commits into
mainfrom
codex/summary-detail-layout
Aug 1, 2026
Merged

Improve summary detail layout#29
MyButtermilk merged 3 commits into
mainfrom
codex/summary-detail-layout

Conversation

@MyButtermilk

Copy link
Copy Markdown
Owner

Summary

  • align the transcript title with the full summary layout instead of offsetting it to the content column
  • move the YouTube source action into the sticky header, with compact responsive and mobile-menu variants
  • keep the summary table of contents at its final sticky position from the initial render

Why

The summary-specific header padding left an unnecessary empty column and reduced the available title width. The standalone YouTube source link also sat above the summary grid, so the table of contents shifted upward before reaching its sticky offset.

User impact

Summary pages use the available horizontal space more effectively, source actions stay grouped together, and the table of contents no longer moves when scrolling begins.

Validation

  • npm run check
  • npm run test — 84 library tests and 35 component tests passed
  • npm run test:i18n
  • Prettier and git diff --check
  • visual browser checks at 2048 px and the 1440 px breakpoint
  • verified the table of contents had the same measured Y position before and after 420 px of scrolling

@MyButtermilk
MyButtermilk marked this pull request as ready for review August 1, 2026 19:52

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 23794cb94e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

data-testid="youtube-source-link"
>
<Youtube className="text-red-600 dark:text-red-400" aria-hidden="true" />
<span className="hidden 2xl:inline">{t("Open on YouTube")}</span>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the YouTube label visible for smoke widths

At the default desktop smoke viewport, this label is display: none because it is hidden until the 2xl breakpoint, leaving only decorative SVGs visible. scripts/smoke_frontend_browser.py still waits for document.body.innerText to contain “Open on YouTube” on /transcript/youtube-processing-smoke, and the smoke browser starts at 1280px wide, so that route will time out even though the link exists. Keep visible text at md/lg widths or update the smoke to assert the aria label instead.

Useful? React with 👍 / 👎.

@MyButtermilk
MyButtermilk merged commit 792bb28 into main Aug 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant