Improve summary detail layout - #29
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 23794cb94e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| data-testid="youtube-source-link" | ||
| > | ||
| <Youtube className="text-red-600 dark:text-red-400" aria-hidden="true" /> | ||
| <span className="hidden 2xl:inline">{t("Open on YouTube")}</span> |
There was a problem hiding this comment.
Keep the YouTube label visible for smoke widths
At the default desktop smoke viewport, this label is display: none because it is hidden until the 2xl breakpoint, leaving only decorative SVGs visible. scripts/smoke_frontend_browser.py still waits for document.body.innerText to contain “Open on YouTube” on /transcript/youtube-processing-smoke, and the smoke browser starts at 1280px wide, so that route will time out even though the link exists. Keep visible text at md/lg widths or update the smoke to assert the aria label instead.
Useful? React with 👍 / 👎.
Summary
Why
The summary-specific header padding left an unnecessary empty column and reduced the available title width. The standalone YouTube source link also sat above the summary grid, so the table of contents shifted upward before reaching its sticky offset.
User impact
Summary pages use the available horizontal space more effectively, source actions stay grouped together, and the table of contents no longer moves when scrolling begins.
Validation
npm run checknpm run test— 84 library tests and 35 component tests passednpm run test:i18ngit diff --check