Skip to content

fix: keep release checksums aligned with asset names - #86

Merged
My-Denia merged 1 commit into
mainfrom
agent/fix-release-checksum-basename
Jul 18, 2026
Merged

fix: keep release checksums aligned with asset names#86
My-Denia merged 1 commit into
mainfrom
agent/fix-release-checksum-basename

Conversation

@My-Denia

Copy link
Copy Markdown
Owner

Description

  • Canonicalize whitespace in staged GitHub Release asset basenames to periods before collision checks, copying, inventory generation, and checksum generation.
  • Extend the existing release-asset utility tests for the final Windows installer basename and post-canonicalization collisions.

Motivation

GitHub normalized the uploaded Windows installer name from CloseScreen Setup 1.5.0-fork.4.exe to CloseScreen.Setup.1.5.0-fork.4.exe after the release workflow had generated and locally verified SHA256SUMS.txt. The bytes and hash were correct, but the published checksum subject did not match the final GitHub asset basename. Staging the canonical basename first keeps checksums aligned with uploaded asset names and prevents silent collisions.

Type of Change

  • Bug Fix

Impact

Release asset staging and checksum generation only. Capture, audio, webcam, editor, exporter, native helpers, and the native helper test harness are unchanged.

Testing

  • npx vitest run electron/native/prepareReleaseAssets.test.mjs — 5 passed
  • npm run test — 63 files, 518 tests passed
  • npm run lint — passed
  • npx tsc --noEmit — passed
  • git diff --check — passed

Uncertain items

None.

Checklist

  • I have performed a self-review of my code.
  • No screenshot or video is applicable to this release-tooling-only fix.
  • No runtime or release tag change is included.

Copilot AI review requested due to automatic review settings July 18, 2026 00:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@My-Denia
My-Denia merged commit 0a65d7b into main Jul 18, 2026
12 checks passed
@My-Denia
My-Denia deleted the agent/fix-release-checksum-basename branch July 18, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants