fix: keep release checksums aligned with asset names - #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation
GitHub normalized the uploaded Windows installer name from
CloseScreen Setup 1.5.0-fork.4.exetoCloseScreen.Setup.1.5.0-fork.4.exeafter the release workflow had generated and locally verifiedSHA256SUMS.txt. The bytes and hash were correct, but the published checksum subject did not match the final GitHub asset basename. Staging the canonical basename first keeps checksums aligned with uploaded asset names and prevents silent collisions.Type of Change
Impact
Release asset staging and checksum generation only. Capture, audio, webcam, editor, exporter, native helpers, and the native helper test harness are unchanged.
Testing
npx vitest run electron/native/prepareReleaseAssets.test.mjs— 5 passednpm run test— 63 files, 518 tests passednpm run lint— passednpx tsc --noEmit— passedgit diff --check— passedUncertain items
None.
Checklist