This repository was archived by the owner on Aug 31, 2026. It is now read-only.
FastJetAlg: fix swapped jetOut / recParticleOut collections - #19
Merged
Merged
Conversation
The MultiTransformer declares its two outputs jets-first:
{KeyValues("jetOut", {"JetOut"}), KeyValues("recParticleOut", {"Constituents"})}
but operator() returned them the other way round, so the collection written
under jetOut received `outputCollection` (the subset of input particles that
were clustered, flagged with setSubsetCollection(true)) and the collection
written under recParticleOut received `jetCollection` (the jets).
The declared order is the intended one -- the default names are "JetOut" for
slot 0 and "Constituents" for slot 1 -- so fix the return, not the declaration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MultiTransformer at k4Reco/FastJet/src/FastJetAlg.cpp#L31-L32 declares its two outputs jets-first:
but operator() returns them the other way round, so the collection written under jetOut receives
outputCollection(the subset of input particles that were clustered, flagged with setSubsetCollection(true)) and the collection written under recParticleOut receivesjetCollection(the jets).This PR swaps the returned tuple.
Checked on a MAIA v3.1 VBF H→bb sample.
MAIAConfig'sfastJet_cfg()names the inputs andoutputs correctly (
recParticleIn = PandoraPFOs,jetOut = JetOut,recParticleOut = UsedPFOs),so this is not a configuration error, but the collections written as
JetOutandUsedPFOscomeout swapped due to the upstream bug. Cross-checked by plotting collections:
JetOuttracks the inputPandoraPFOson every variable.UsedPFOsreproduces jets from standalone anti-kt onPandoraPFOs, jet by jet.