Skip to content

💥 Remove the calibration advisory property - #512

Open
burgholzer wants to merge 1 commit into
v1.4from
codex/remove-needs-calibration
Open

💥 Remove the calibration advisory property#512
burgholzer wants to merge 1 commit into
v1.4from
codex/remove-needs-calibration

Conversation

@burgholzer

@burgholzer burgholzer commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

🤖 AI text below 🤖

Description

Remove the unused QDMI_DEVICE_PROPERTY_NEEDSCALIBRATION advisory and close the regular property-enum gap. Preserve QDMI_DEVICE_STATUS_CALIBRATION and calibration-job submission. Provider-specific calibration readiness can use a custom property.

This is the first independent metadata-cleanup layer, based directly on v1.4; #513 follows it. It does not include payload capabilities, multi-program jobs, or replaceable drivers. The breaking development headers are identified as 1.4.0-dev.

Validation

  • Release configure/build: passed, including example and template targets.
  • CTest: 83 passed; 18 expected read-only job tests skipped; no failures.
  • uvx prek run -a: passed.
  • Rebased commit signed and verified. Fresh hosted CI is pending; earlier-stack results are not evidence for this head.

AI assistance: Codex separated the stack, adapted the cleanup to develop, and ran local validation.

Consumer compatibility

Removing the advisory does not remove calibration-job submission or the CALIBRATION status. Keep provider-specific calibration readiness and workflows in documented extensions; no common calibration workflow is standardized here.

Before the interface change merges, link a working Core consumer and a demonstration with at least one existing provider, preferably both where applicable. Compatibility evidence suffices when a provider needs no changes. Development revisions may support these tests; published artifacts must use released dependencies. Core adoption: #2233.

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

If PR contains AI-assisted content:

  • I have disclosed the use of AI tools in the PR description as per our AI Usage Guidelines.
  • AI-assisted commits include an Assisted-by: [Model Name] via [Tool Name] footer.
  • I confirm that I have personally reviewed and understood all AI-generated content, and accept full responsibility for it.

@burgholzer burgholzer added documentation Improvements or additions to documentation minor Changes that warrant a minor version release code quality Chages regarding code quality labels Aug 24, 2026
@burgholzer burgholzer self-assigned this Aug 24, 2026
@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://Munich-Quantum-Software-Stack.github.io/QDMI/pr-preview/pr-512/

Built to branch gh-pages at 2026-09-05 14:30 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@burgholzer
burgholzer force-pushed the codex/remove-needs-calibration branch 2 times, most recently from 2583d9b to d358e6b Compare August 24, 2026 19:30
@burgholzer
burgholzer force-pushed the codex/remove-needs-calibration branch from d358e6b to 2c636b9 Compare August 24, 2026 19:35
@burgholzer
burgholzer marked this pull request as ready for review August 24, 2026 19:42
@burgholzer burgholzer added this to the v1.4.0 milestone Aug 24, 2026
@burgholzer
burgholzer force-pushed the codex/remove-needs-calibration branch from 2c636b9 to f921642 Compare September 4, 2026 09:28
@burgholzer
burgholzer changed the base branch from codex/client-driver-abi-stable-ids to develop September 4, 2026 09:33
@burgholzer
burgholzer changed the base branch from develop to v1.4 September 4, 2026 14:55
Drop the unused NEEDSCALIBRATION device property and close the resulting enum gap. Keep calibration-job submission and the distinct calibration status.

Keep this cleanup independent of payload and driver changes. Mark its breaking headers as 1.4.0-dev instead of inheriting the 1.3.4 development version.

Assisted-by: GPT-5.6 Sol via Codex
@burgholzer
burgholzer force-pushed the codex/remove-needs-calibration branch from f921642 to 3e2e11a Compare September 5, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality Chages regarding code quality documentation Improvements or additions to documentation minor Changes that warrant a minor version release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant