Skip to content

Fix remove portal from config not applying correctly #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benwoo1110 merged 1 commit into from
Mar 4, 2026
+5 −4
Merged

Fix remove portal from config not applying correctly #706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/main/java/org/mvplugins/multiverse/portals/utils/PortalManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,16 +174,17 @@ private MVPortal removePortal(String portalName, boolean removeFromConfigs, bool
if (!isPortal(portalName)) {
return null;
}

MVPortal removed = this.portals.remove(portalName);
MultiverseWorld world = this.worldManager.getLoadedWorld(removed.getWorld()).getOrNull();
removeFromWorldChunkPortals(world, removed);

if (removeFromConfigs) {
FileConfiguration config = this.plugin.getPortalsConfig();
config.set("portals." + portalName, null);
this.plugin.savePortalsConfig();
}

MVPortal removed = this.portals.remove(portalName);
MultiverseWorld world = this.worldManager.getLoadedWorld(removed.getWorld()).getOrNull();
removeFromWorldChunkPortals(world, removed);

removed.removePermission();
Permission portalAccess = this.plugin.getServer().getPluginManager().getPermission("multiverse.portal.access.*");
Permission exemptAccess = this.plugin.getServer().getPluginManager().getPermission("multiverse.portal.exempt.*");
Expand Down
Loading