This repository was archived by the owner on Jan 14, 2025. It is now read-only.
Refactor time!#2
Open
timothyekl wants to merge 5 commits intomasterfrom
Open
Conversation
Also compresses down wiki handlers into a single handler using regex magic and judicious ternary operators. (Told you it was refactor time.)
Also minor fixes for page scraping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@fernferret said (secretly in a comment in the source) that he wanted a refactor on some of this code, and it looked fun. Here goes:
handlerswith individual files per-handlerThere's probably still more that can be done in
handlers.rb, but it's a start.