add smartASS killrot fallback#2146
Open
b0red-man wants to merge 1 commit intoMuMech:devfrom
Open
Conversation
| Engage(false); | ||
| } | ||
|
|
||
| public override void Drive(FlightCtrlState s) |
Collaborator
There was a problem hiding this comment.
Does this need to be in Drive() as opposed to OnFixedUpdate() later in the code?
If it does, it is probably worth a short comment on why. It is mostly just touching internal state and not the flight controls (which is what is in my mental model of why you need to use Drive(), but the details on that kinda paged out of my brain a few years ago).
Contributor
Author
There was a problem hiding this comment.
I put this in Drive() so the check only runs when SmartASS is active. Switching to OnFixedUpdate() would require more checks to make sure the module is active (and also to prevent edge cases where it switched to KILLROT even when the module isn't active)
I can change the code to use OnFixedUpdate if you prefer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #1910, sets smartASS to killrot if all nodes were deleted and was in NODE mode