feat(commerce): added CommerceListingsPagination and genArgsPagination for pagination handling#8
Open
zombozo12 wants to merge 1 commit into
Open
feat(commerce): added CommerceListingsPagination and genArgsPagination for pagination handling#8zombozo12 wants to merge 1 commit into
zombozo12 wants to merge 1 commit into
Conversation
…n for pagination handling
zombozo12
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
CommerceListingsPaginationandgenArgsPaginationfor pagination handling.CommerceListingsPaginationis a separated function because we cannot combineidsquery withpage&pageSizequeries, it will ignore pagination and returns list of listing items.Examples
/api/commerce/listings?ids=1,2,3&page=0&pageSize=1Expected:
Returns 1 item each page
Got:
List of 1,2, and 3 item listings, pagination ignored.
Thus, the function is separated due to Guild Wars 2 API not supporting combining
idsand pagination.