Fix i18n two letter language code check - #262
Open
DarkDefender wants to merge 1 commit into
Open
Conversation
Before this fix, various language codes (like "en_NL") would fail and erronosly pick something like "fr_FR". This is because the "_" check in this while loop would push the index for "lang_code" out of bounds and could potentially make the function return a false positive. As all first two letter combinations are the same for each lang_code entry, instead just do a direct comparison between the first variant in the lang_code array and lang.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this fix, various language codes (like "en_NL") would fail and erronosly pick something like "fr_FR".
This is because the "_" check in this while loop would push the index for "lang_code" out of bounds and could potentially make the function return a false positive.
As all first two letter combinations are the same for each lang_code entry, instead just do a direct comparison between the first variant in the lang_code array and lang.