Skip to content

Enable mypy#1168

Merged
tysmith merged 3 commits into
masterfrom
enable-mypy
Apr 28, 2026
Merged

Enable mypy#1168
tysmith merged 3 commits into
masterfrom
enable-mypy

Conversation

@tysmith
Copy link
Copy Markdown
Contributor

@tysmith tysmith commented Apr 23, 2026

Enable mypy for FTB, Collector and Reporter.

@tysmith tysmith requested a review from a team as a code owner April 23, 2026 22:50
@sentry
Copy link
Copy Markdown

sentry Bot commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 79.79381% with 98 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.33%. Comparing base (2c9dc59) to head (6570c6b).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
FTB/Signatures/CrashSignature.py 57.77% 19 Missing ⚠️
FTB/Running/AutoRunner.py 37.03% 17 Missing ⚠️
FTB/Signatures/CrashInfo.py 85.83% 17 Missing ⚠️
FTB/Running/GDB.py 0.00% 16 Missing ⚠️
Collector/Collector.py 63.63% 12 Missing ⚠️
FTB/Running/PersistentApplication.py 78.57% 12 Missing ⚠️
FTB/Signatures/Matchers.py 94.44% 2 Missing ⚠️
FTB/Signatures/Symptom.py 96.29% 2 Missing ⚠️
FTB/Signatures/JSONHelper.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1168      +/-   ##
==========================================
+ Coverage   63.27%   63.33%   +0.06%     
==========================================
  Files         177      177              
  Lines       12078    12186     +108     
  Branches      877      551     -326     
==========================================
+ Hits         7642     7718      +76     
- Misses       4402     4434      +32     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tysmith tysmith force-pushed the enable-mypy branch 2 times, most recently from fb133c5 to 3039e2b Compare April 28, 2026 19:18
@tysmith tysmith merged commit 5ea0a6a into master Apr 28, 2026
11 checks passed
@tysmith tysmith deleted the enable-mypy branch April 28, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants