fix(ci): deduplicate fleet label validation - #205
Open
Giselle Rogers (gbrogers) wants to merge 1 commit into
Open
fix(ci): deduplicate fleet label validation#205Giselle Rogers (gbrogers) wants to merge 1 commit into
Giselle Rogers (gbrogers) wants to merge 1 commit into
Conversation
Confidence Score: 5/5The PR appears safe to merge because the removed validation is still performed by the canonical label-aware Validate workflow for pull requests. The change only removes a duplicate CI job, and the remaining Validate workflow continues to execute the package-index validator on pull-request code and label changes. Reviews (1): Last reviewed commit: "fix(ci): deduplicate fleet label validat..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The Tests workflow only responds to the default pull_request activity types, while the duplicate validator depends on PR labels. The canonical Validate workflow already responds to labeled and unlabeled events and is the required status check for staging.
Testing