Skip to content

fix(vscode): support reviewing question answers - #2467

Open
ousamabenyounes wants to merge 2 commits into
MoonshotAI:mainfrom
ousamabenyounes:fix/issue-2350
Open

fix(vscode): support reviewing question answers#2467
ousamabenyounes wants to merge 2 commits into
MoonshotAI:mainfrom
ousamabenyounes:fix/issue-2350

Conversation

@ousamabenyounes

@ousamabenyounes ousamabenyounes commented Jul 31, 2026

Copy link
Copy Markdown

Fixes #2350.

Summary

  • keep AskUserQuestion choices in an explicit review flow instead of advancing or submitting on selection
  • support multi-select options, custom-only answers, and combined preset/custom answers
  • let users navigate back without losing selections and require an explicit final submission
  • allow users to remove a previously saved custom multi-select answer while preserving preset selections
  • prevent duplicate question RPCs while submission is in flight
  • add reducer-level and React/jsdom interaction coverage

Test verification (RED → GREEN)

  • RED: the original flow tests failed before the question-flow implementation existed
  • RED follow-up: clearing a reviewed custom answer left an empty custom key and the UI disabled saving the removal (2 focused failures)
  • GREEN: targeted reducer and React interaction suite passes all 8 tests
  • VS Code extension suite: 16 files / 316 tests passed
  • full local suite: lint, typecheck, production build, 1,037 files and 16,905 tests passed versus the upstream baseline of 1,035 files and 16,897 tests
  • independent code review: PASS

AI assistance disclosure

This patch and PR text were AI-assisted using OpenAI Codex. The implementation was exercised with targeted UI tests and the complete local validation suite; the human contributor remains responsible for reviewing and understanding the submitted changes.

@changeset-bot

changeset-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ef1693a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
kimi-code Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c783d71662

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread apps/vscode/webview-ui/src/components/QuestionDialog.tsx Outdated
@pkg-pr-new

pkg-pr-new Bot commented Jul 31, 2026

Copy link
Copy Markdown
pnpm dlx https://pkg.pr.new/@moonshot-ai/kimi-code@c783d71
npx https://pkg.pr.new/@moonshot-ai/kimi-code@c783d71

commit: c783d71

@ousamabenyounes

Copy link
Copy Markdown
Author

Addressed the review-flow edge case in ef1693adf: clearing a saved custom multi-select response now removes it while retaining selected preset options; new blank custom responses remain blocked.

Validation: reproduced 2 focused RED failures, then 8/8 focused tests GREEN. run-ci.sh improved from the upstream baseline of 16,897 passing tests to 16,905 with lint, typecheck, and build GREEN. GitHub currently reports no visible checks for this exact SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 bugs together ~~

1 participant