Skip to content

fix: avoid Windows console font reset#2289

Open
he-yufeng wants to merge 1 commit into
MoonshotAI:mainfrom
he-yufeng:fix/windows-kaos-no-window
Open

fix: avoid Windows console font reset#2289
he-yufeng wants to merge 1 commit into
MoonshotAI:mainfrom
he-yufeng:fix/windows-kaos-no-window

Conversation

@he-yufeng
Copy link
Copy Markdown

@he-yufeng he-yufeng commented May 14, 2026

Fixes #2197.

Summary

  • pass CREATE_NO_WINDOW when LocalKaos.exec() creates subprocesses on Windows
  • keep the existing subprocess behavior unchanged on non-Windows platforms
  • add a focused regression test that verifies the Windows creation flag is passed

To verify

  • python -m py_compile packages\\kaos\\src\\kaos\\local.py packages\\kaos\\tests\\test_local_kaos.py
  • uv run ruff check packages\\kaos\\src\\kaos\\local.py packages\\kaos\\tests\\test_local_kaos.py
  • uv run pyright packages\\kaos\\src\\kaos\\local.py packages\\kaos\\tests\\test_local_kaos.py
  • uv run pytest packages\\kaos\\tests\\test_local_kaos.py -q -k "exec_uses_create_no_window_on_windows or exec_runs_command_and_streams" --basetemp .tmp\\pytest -p no:cacheprovider

Open in Devin Review

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows console TrueType font reset when running subprocess via kaos.exec()

1 participant