fix(fly.mainnet.toml): comment out stale STELLAR_RPC_URL#33
Merged
Conversation
STELLAR_RPC_URL on mainnet-pay is set via Fly secret (Quasar Pro URL with embedded auth token). The literal 'https://soroban-testnet.stellar.org' in fly.mainnet.toml's [env] was stale — pointing at testnet RPC on the mainnet config. Fly secrets override fly.toml [env] at runtime, so the misleading value was a no-op functionally, but a footgun for anyone reading the TOML to understand deployed config. Replaced with the same convention used for SERVICE_DOMAIN / SERVICE_AUTH_SECRET / OTEL_EXPORTER_OTLP_*. No runtime change. Mirrors council-platform#39 fix; cleanup-candidate #6 in pm-theahaco/env-vars.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fly.mainnet.tomlhadSTELLAR_RPC_URL = 'https://soroban-testnet.stellar.org'in[env]— testnet URL on the mainnet TOML. Fly secret of the same name (Quasar Pro URL with embedded auth token) overrides this at runtime, so the stale literal was functionally a no-op but a footgun for anyone reading the TOML to understand deployed config.# X — set via Fly secrets per environmentconvention used forSERVICE_DOMAIN/SERVICE_AUTH_SECRET/ OTEL_EXPORTER_OTLP_*.flyctl ssh ... printenv STELLAR_RPC_URLonmoonlight-mainnet-paystill returns the Fly-secret value (Quasar Pro URL).Mirrors
council-platform#39. Phase 4 of build-env-registry-4. Cleanup-candidate #6 inpm-theahaco/env-vars.md.Test plan
deno fmt --check,deno lint,deno check src/main.ts— local, all cleanflyctl secrets unset CHALLENGE_TTL MODE OTEL_DENO OTEL_EXPORTER_OTLP_PROTOCOL OTEL_SERVICE_NAME SESSION_TTL --app moonlight-mainnet-payso TOML [env] becomes the sole source for these 6 non-sensitive values. Runtime printenv verified post-unset.